Enforce invariant that storage_ is always non-null #12328
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Differential Revision: D10200448 Differential Version: 59721171
Contributor
Author
|
@pytorchbot retest this please |
dzhulgakov
approved these changes
Oct 5, 2018
Collaborator
dzhulgakov
left a comment
dzhulgakov
left a comment
There was a problem hiding this comment.
Thank you sir, looks legit!
zdevito
pushed a commit
to zdevito/ATen
that referenced
this pull request
Oct 5, 2018
Summary: Pull Request resolved: pytorch/pytorch#12328 - Delete reset() from Storage, as it makes it easy to accidentally create a null storage. - Immediately reject a storage if it is null when passed in Reviewed By: dzhulgakov Differential Revision: D10200448 fbshipit-source-id: 14bfa45f8f59859cc350bd9e20e3ef8692e3991d
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack:
:black_circle: #12328 Enforce invariant that storage_ is always non-null 💛
create a null storage.
Differential Revision: D10200448