[ROCm] Enable sparse functionality and tests #12323
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Enable sparse functions for ROCm * Reenable test_sparse unit tests that are now passing in ROCm (#208) * Reenable test_sparse unit tests that are now passing * It's a flaky test for us - skip.
iotamudelta
requested review from
apaszke,
colesbury,
ezyang,
gchanan,
soumith and
zdevito
as code owners
Contributor
|
@pytorchbot retest this please |
Contributor
Contributor
facebook-github-bot
left a comment
facebook-github-bot
left a comment
There was a problem hiding this comment.
bddppq has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Contributor
Author
zdevito
pushed a commit
to zdevito/ATen
that referenced
this pull request
Oct 4, 2018
Summary: * Enable sparse functions for ROCm * Reenable test_sparse unit tests that are now passing in ROCm ezyang bddppq Pull Request resolved: pytorch/pytorch#12323 Differential Revision: D10203540 Pulled By: bddppq fbshipit-source-id: 33ffcfbda32875676c27b33ad1e7cd96fbadc790
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enable sparse functions for ROCm
Reenable test_sparse unit tests that are now passing in ROCm
@ezyang @bddppq