Add utility function make_tensor #12288
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devashisht
requested review from
apaszke,
colesbury,
ezyang,
gchanan,
soumith and
zdevito
as code owners
devashisht
force-pushed
the
export-D10152661
branch
from
42aaa29 to
16274c8
Compare
ezyang
approved these changes
Oct 3, 2018
Contributor
|
cc @gchanan |
devashisht
force-pushed
the
export-D10152661
branch
from
16274c8 to
c9cf78c
Compare
apaszke
reviewed
Oct 3, 2018
Summary: Pull Request resolved: pytorch#12288 Current implementation of Tensor takes an intrusive_ptr as an argument for storing data. But instead of requiring users to explicitly pass an intrusive_ptr we want them to pass args for intrusive ptr directly which are forwarded internally through new helper function called make_tensor Reviewed By: ezyang Differential Revision: D10152661 fbshipit-source-id: 8dbf73a552c8ccc26918005b211d385dd4030f8c
devashisht
force-pushed
the
export-D10152661
branch
from
c9cf78c to
dd5a9cd
Compare
zdevito
pushed a commit
to zdevito/ATen
that referenced
this pull request
Oct 5, 2018
Summary: Pull Request resolved: pytorch/pytorch#12288 Current implementation of Tensor takes an intrusive_ptr as an argument for storing data. But instead of requiring users to explicitly pass an intrusive_ptr we want them to pass args for intrusive ptr directly which are forwarded internally through new helper function called make_tensor Reviewed By: ezyang Differential Revision: D10152661 fbshipit-source-id: bfa72de161ace3fd1c4573427abcd1bfbd12e29e
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Current implementation of Tensor takes an intrusive_ptr as an argument for storing data. But instead of requiring users to explicitly pass an intrusive_ptr we want them to pass args for intrusive ptr directly which are forwarded internally through new helper function called make_tensor
Differential Revision: D10152661