-
Notifications
You must be signed in to change notification settings - Fork 26.3k
Delete torch.autograd.function.traceable APIs #122817
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
We deprecated them in 2.3 with plans to delete in 2.4. Very few OSS repos use this flag at all and it also does nothing. [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/122817
Note: Links to docs will display an error until the docs builds have been completed. ✅ You can merge normally! (1 Unrelated Failure)As of commit 464ab70 with merge base eb5381d ( FLAKY - The following job failed but was likely due to flakiness present on trunk:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
albanD
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code cleanup 🎉
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
We deprecated them in 2.3 with plans to delete in 2.4. Very few OSS repos use this flag at all and it also does nothing. Pull Request resolved: pytorch#122817 Approved by: https://github.com/albanD
Stack from ghstack (oldest at bottom):
We deprecated them in 2.3 with plans to delete in 2.4. Very few OSS
repos use this flag at all and it also does nothing.