Skip to content

Avoid COW materialize in nn.functional forward ops (3) #122443

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
kurtamohler wants to merge 5 commits into from
Closed

Avoid COW materialize in nn.functional forward ops (3) #122443

kurtamohler wants to merge 5 commits into from

Conversation

@kurtamohler
Copy link
Collaborator

@kurtamohler kurtamohler commented Mar 21, 2024 •
edited
Loading

Stack from ghstack (oldest at bottom):

Affected ops:

  • repeat
  • unfold
  • logsigmoid
  • pixel_shuffle/unshuffle
  • remaining norm ops

cc @jgong5 @mingfeima @XiaobingSuper @sanchitintel @ashokei @jingxu10

@kurtamohler
Avoid COW materialize in nn.functional forward ops (3)
deafc3b 
Affected ops:
* repeat
* unfold
* logsigmoid
* pixel_shuffle/unshuffle
* remaining norm ops

[ghstack-poisoned]
@kurtamohler kurtamohler requested a review from mruberry as a code owner March 21, 2024 22:24
This was referenced Mar 21, 2024
Closed
Closed
@pytorch-bot
Copy link

pytorch-bot bot commented Mar 21, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/122443

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit df7fa9c with merge base ebde6c7 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@kurtamohler kurtamohler mentioned this pull request Mar 21, 2024
Closed
@pytorch-bot pytorch-bot bot added the module: cpu CPU specific problem (e.g., perf, algorithm) label Mar 21, 2024
@kurtamohler
Copy link
Collaborator Author

kurtamohler commented Mar 21, 2024

This contains all the changes from #121537 except for the changes to conv ops (which I suspect is what caused the CI failures) and changes to the unit test

@kurtamohler
Update on "Avoid COW materialize in nn.functional forward ops (3)"
d3632d7 
Affected ops:
* repeat
* unfold
* logsigmoid
* pixel_shuffle/unshuffle
* remaining norm ops

cc jgong5 mingfeima XiaobingSuper sanchitintel ashokei jingxu10

[ghstack-poisoned]
kurtamohler added a commit that referenced this pull request Mar 21, 2024
@kurtamohler
Avoid COW materialize in nn.functional forward ops (3)
115f751 
Affected ops:
* repeat
* unfold
* logsigmoid
* pixel_shuffle/unshuffle
* remaining norm ops

ghstack-source-id: 2edc4bf
Pull Request resolved: #122443
@kurtamohler
Update on "Avoid COW materialize in nn.functional forward ops (3)"
237c7cb 
Affected ops:
* repeat
* unfold
* logsigmoid
* pixel_shuffle/unshuffle
* remaining norm ops

cc jgong5 mingfeima XiaobingSuper sanchitintel ashokei jingxu10

[ghstack-poisoned]
kurtamohler added a commit to kurtamohler/pytorch that referenced this pull request Mar 25, 2024
@kurtamohler
Avoid COW materialize in nn.functional forward ops (3)
b40c0f8 
Affected ops:
* repeat
* unfold
* logsigmoid
* pixel_shuffle/unshuffle
* remaining norm ops

ghstack-source-id: 2edc4bf
Pull Request resolved: pytorch#122443
@kurtamohler
Update on "Avoid COW materialize in nn.functional forward ops (3)"
e009c76 
Affected ops:
* repeat
* unfold
* logsigmoid
* pixel_shuffle/unshuffle
* remaining norm ops

cc jgong5 mingfeima XiaobingSuper sanchitintel ashokei jingxu10

[ghstack-poisoned]
@kurtamohler kurtamohler added the topic: not user facing topic category label Mar 25, 2024
@kurtamohler kurtamohler requested a review from ezyang March 25, 2024 17:36
@ezyang
Copy link
Contributor

ezyang commented Mar 25, 2024

@pytorchbot merge -i

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Mar 25, 2024
@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Mar 25, 2024

Merge started

Your change will be merged while ignoring the following 1 checks: pull / linux-focal-py3_8-clang9-xla / test (xla, 1, 1, linux.12xlarge)

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Mar 25, 2024

Merge failed

Reason: 1 jobs have failed, first few of them are: trunk / macos-12-py3-arm64 / build

Details for Dev Infra team Raised by workflow job

@kurtamohler
Update on "Avoid COW materialize in nn.functional forward ops (3)"
df7fa9c 
Affected ops:
* repeat
* unfold
* logsigmoid
* pixel_shuffle/unshuffle
* remaining norm ops

cc jgong5 mingfeima XiaobingSuper sanchitintel ashokei jingxu10

[ghstack-poisoned]
@kurtamohler kurtamohler requested a review from kulinseth as a code owner March 25, 2024 21:59
@kurtamohler kurtamohler requested a review from malfet as a code owner March 25, 2024 21:59
@pytorch-bot pytorch-bot bot added the ciflow/mps Run MPS tests (subset of trunk) label Mar 25, 2024
kurtamohler added a commit that referenced this pull request Mar 25, 2024
@kurtamohler
Avoid COW materialize in nn.functional forward ops (3)
83b8564 
Affected ops:
* repeat
* unfold
* logsigmoid
* pixel_shuffle/unshuffle
* remaining norm ops

ghstack-source-id: 27b8316
Pull Request resolved: #122443
@kurtamohler
Copy link
Collaborator Author

kurtamohler commented Mar 26, 2024

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Mar 26, 2024

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

pytorch-bot bot pushed a commit that referenced this pull request Apr 22, 2024
@kurtamohler
Avoid COW materialize in nn.functional forward ops (3) (#122443)
451f4df 
Affected ops:
* repeat
* unfold
* logsigmoid
* pixel_shuffle/unshuffle
* remaining norm ops

Pull Request resolved: #122443
Approved by: https://github.com/ezyang
@github-actions github-actions bot deleted the gh/kurtamohler/19/head branch April 25, 2024 01:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ezyang ezyang ezyang approved these changes

@mruberry mruberry Awaiting requested review from mruberry

@kulinseth kulinseth Awaiting requested review from kulinseth

@malfet malfet Awaiting requested review from malfet

Assignees

No one assigned

Labels

ciflow/mps Run MPS tests (subset of trunk) ciflow/trunk Trigger trunk jobs on your pull request Merged module: cpu CPU specific problem (e.g., perf, algorithm) open source topic: not user facing topic category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@kurtamohler @ezyang @pytorchmergebot @pytorchbot