Delete stride updating logic from Caffe2, and make PyTorch error in this case. #12236
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Differential Revision: D10134319 Differential Version: 59382207
Differential Revision: D10134319 Differential Version: 59382682
Differential Revision: D10134319 Differential Version: 59385053
Differential Revision: D10134319 Differential Version: 59396527
zdevito
pushed a commit
to zdevito/ATen
that referenced
this pull request
Oct 2, 2018
…his case. (#12236) Summary: Strides appear to cause a huge memory regression in some of our internal training workflows. This diff stems the bleeding, while we figure out exactly what happened. Pull Request resolved: pytorch/pytorch#12236 Reviewed By: dzhulgakov Differential Revision: D10134319 fbshipit-source-id: 1547c89a65c05473c409c0977c19c99dcaefb89c
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack:
:black_circle: #12236 Delete stride updating logic from Caffe2, and make PyTorch error in this case. 💛
Differential Revision: D10134319