cleanup controlflow #12235
Closed
cleanup controlflow #12235
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Pull Request resolved: pytorch#12235 SSA is actually implicitly maintained so not only was this function not implemented, it never should be implemented. Reviewed By: duc0 Differential Revision: D10133928 fbshipit-source-id: 01b8cc8732a046fead487cecdd6309108166439a
bwasti
force-pushed
the
export-D10133928
branch
from
681243c to
6b0f2b5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: SSA is actually implicitly maintained so not only was this function not implemented, it never should be implemented.
Differential Revision: D10133928