remove support for c extensions #12122
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
li-roy
requested review from
apaszke,
colesbury,
ezyang,
gchanan,
soumith and
zdevito
as code owners
Collaborator
|
Could you still keep |
li-roy
force-pushed
the
export-D10060541
branch
from
db3eea9 to
60c0301
Compare
Summary: Pull Request resolved: pytorch#12122 We are deprecating support for c extensions. Please use cpp extension in the future. Differential Revision: D10060541 fbshipit-source-id: 800434b10b27e32978d5f15b0a99636d6f4083d9
li-roy
force-pushed
the
export-D10060541
branch
from
60c0301 to
d969e20
Compare
Collaborator
|
Thanks! |
Contributor
|
This breaking change is not in the release doc. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: We are deprecating support for c extensions. Please use cpp extension in the future.
Differential Revision: D10060541