Back out "[pytorch][PR] Revert "Move CreateContext to global registry (#11688)"" #12055
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Differential Revision: D10033396 Differential Version: 58815881
ezyang
reviewed
Sep 25, 2018
caffe2/core/context_base.h
Outdated
| #include "caffe2/core/logging.h" | ||
| #include "caffe2/proto/caffe2_pb.h" | ||
|
|
||
| namespace caffe2 {} // namespace caffe2 |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
Differential Revision: D10033396 Differential Version: 58856963
Contributor
Author
|
@pytorchbot retest this please |
1 similar comment
Contributor
Author
|
@pytorchbot retest this please |
This was referenced Sep 26, 2018
ezyang
approved these changes
Sep 27, 2018
Contributor
ezyang
left a comment
ezyang
left a comment
There was a problem hiding this comment.
Approved via ghapprove D10033396
ezyang
previously approved these changes
Sep 27, 2018
Contributor
ezyang
left a comment
ezyang
left a comment
There was a problem hiding this comment.
Approved via ghapprove D10033396
ezyang
approved these changes
Sep 27, 2018
Contributor
ezyang
left a comment
ezyang
left a comment
There was a problem hiding this comment.
Approved via ghapprove -s D10033396
ezyang
previously approved these changes
Sep 27, 2018
Contributor
ezyang
left a comment
ezyang
left a comment
There was a problem hiding this comment.
Approved via ghapprove -s D10033396
ezyang
approved these changes
Sep 27, 2018
Contributor
ezyang
left a comment
ezyang
left a comment
There was a problem hiding this comment.
Approved via ghapprove -s D10033396 --skip-phabricator
Differential Revision: D10033396 Differential Version: 59085834
jerryzh168
added a commit
to jerryzh168/pytorch
that referenced
this pull request
Sep 28, 2018
…pytorch#11688)"" (pytorch#12121) Summary: Pull Request resolved: pytorch#12121 Pull Request resolved: pytorch#12055 Original commit changeset: 6ca9de65b707 Reviewed By: ezyang Differential Revision: D10033396 fbshipit-source-id: 0936ccbeae529119586e41dd1a687f5ef1f85c8f
Differential Revision: D10033396 Differential Version: 59227528
zdevito
pushed a commit
to zdevito/ATen
that referenced
this pull request
Oct 1, 2018
… (#11688)"" (#12121) Summary: Pull Request resolved: pytorch/pytorch#12121 Pull Request resolved: pytorch/pytorch#12055 Original commit changeset: 6ca9de65b707 Reviewed By: ezyang Differential Revision: D10033396 fbshipit-source-id: ca9f4b2f7ef0561f619b833415d394a8b9972bf4
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack:
:black_circle: #12055 Back out "[pytorch][PR] Revert "Move CreateContext to global registry (#11688)"" 💛
:white_circle: #12029 [pt1][tensor] New in StaticContext returns at::DataPtr 💛
:white_circle: #12105 [pt1][tensor] Split Allocator 💛
:white_circle: #12111 [pt1][tensor] Remove New with Allocator Registry 💛
Original commit changeset: 6ca9de65b707
Differential Revision: D10033396