Fix ONNX bug, add symbolic for full #12052
Conversation
apaszke
requested review from
Yangqing,
anderspapitto,
bddppq,
dzhulgakov,
ezyang,
houseroad,
jamesr66a and
smessmer
as code owners
houseroad
left a comment
houseroad
left a comment
There was a problem hiding this comment.
Overall, LG, can you add some test cases either in https://github.com/pytorch/pytorch/blob/master/test/onnx/test_operators.py or https://github.com/pytorch/pytorch/blob/master/test/onnx/test_pytorch_onnx_caffe2.py, or both? Thanks
| const_value = _maybe_get_const(value, 't') | ||
| if _is_value(const_value): | ||
| tmp = zeros(shape, scalar_type, layout, device) | ||
| return add(tmp, value, g.op("Constant", value_t=torch.tensor(1))) |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
houseroad
left a comment
houseroad
left a comment
There was a problem hiding this comment.
The expect file looks correct, but very complicated.
facebook-github-bot
left a comment
facebook-github-bot
left a comment
There was a problem hiding this comment.
apaszke has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
4 participants
No description provided.