Skip to content

Revert "use two pass reduction for deterministic reduction order (#11… #120243

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
atalman wants to merge 1 commit into from
Closed

Revert "use two pass reduction for deterministic reduction order (#11… #120243

atalman wants to merge 1 commit into from

Conversation

@atalman
Copy link
Contributor

@atalman atalman commented Feb 20, 2024 •
edited
Loading

This reverts commit cc7ef43.

Manual revert because of the conflict in: test/inductor/test_cpu_repro.py , conflict with this PR: #118365

cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @peterbell10 @ipiszy @yf225 @chenyang78 @kadeng @muchulee8 @aakhundov @ColinPeppler @amjames

@pytorch-bot
Copy link

pytorch-bot bot commented Feb 20, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/120243

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (5 Unrelated Failures)

As of commit d20c499 with merge base 5f3f8fd (image):

FLAKY - The following jobs failed but were likely due to flakiness present on trunk:

BROKEN TRUNK - The following jobs failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

malfet
malfet approved these changes Feb 20, 2024
View reviewed changes
Copy link
Contributor

@malfet malfet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please mention in comment what conflicts you had to revert

@huydhn huydhn added ciflow/rocm Trigger "default" config CI on ROCm test-config/default labels Feb 20, 2024
@atalman
Copy link
Contributor Author

atalman commented Feb 20, 2024

@pytorchmergebot merge -f "most tests are passing"

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Feb 20, 2024

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@huydhn huydhn huydhn approved these changes

@malfet malfet malfet approved these changes

Assignees

No one assigned

Labels

ciflow/inductor ciflow/rocm Trigger "default" config CI on ROCm Merged module: inductor test-config/default

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@atalman @pytorchmergebot @huydhn @malfet