Refactor out shape test into InputMetadata::maybe_reduce #119559
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I'm going to gut this function shortly, and having it all on InputMetadata is convenient for this purpose. Signed-off-by: Edward Z. Yang <[email protected]> [ghstack-poisoned]
This was referenced Feb 9, 2024
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/119559
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 03dd3eb with merge base 24bdd03 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
github-actions
bot
requested review from
SherlockNoMad,
antoniojkim,
bdhirsh and
miladm
soulitzer
approved these changes
Feb 9, 2024
albanD
reviewed
Feb 9, 2024
Collaborator
albanD
left a comment
albanD
left a comment
There was a problem hiding this comment.
The name is reversed but otherwise sounds fine.
I'm going to gut this function shortly, and having it all on InputMetadata is convenient for this purpose. Signed-off-by: Edward Z. Yang <ezyangmeta.com> [ghstack-poisoned]
ezyang
changed the title
Contributor
Author
|
@pytorchbot merge |
Collaborator
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
pytorchmergebot
pushed a commit
that referenced
this pull request
Feb 13, 2024
Fixes #119476 Signed-off-by: Edward Z. Yang <[email protected]> Pull Request resolved: #119562 Approved by: https://github.com/albanD ghstack dependencies: #119559
clee2000
pushed a commit
that referenced
this pull request
Feb 14, 2024
I'm going to gut this function shortly, and having it all on InputMetadata is convenient for this purpose. Signed-off-by: Edward Z. Yang <[email protected]> Pull Request resolved: #119559 Approved by: https://github.com/soulitzer
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
I'm going to gut this function shortly, and having it all on
InputMetadata is convenient for this purpose.
Signed-off-by: Edward Z. Yang [email protected]