Skip to content

Conversation

@brianjo
Copy link
Contributor

@brianjo brianjo commented Sep 21, 2018

Deleted this section by mistake in last PR.

@ssnl
Copy link
Collaborator

ssnl commented Sep 21, 2018

Hey @brianjo, I've fixed the conflict for you, but next time please rebase before committing any changes. Also I'd suggest using branch other than master on your fork to do development. It makes merging easier :)

@ssnl
Copy link
Collaborator

ssnl commented Sep 21, 2018

CI failures are not your fault. Landing.

Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SsnL is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants