Retainable is no more #11900
Closed
Retainable is no more #11900
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Differential Revision: D9977505 Differential Version: 58461947
ezyang
requested review from
apaszke,
colesbury,
gchanan,
soumith and
zdevito
as code owners
gchanan
approved these changes
Sep 20, 2018
Contributor
facebook-github-bot
left a comment
facebook-github-bot
left a comment
There was a problem hiding this comment.
ezyang is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
zdevito
pushed a commit
to zdevito/ATen
that referenced
this pull request
Sep 21, 2018
Summary: Stack: :black_circle: **#11900 Retainable is no more** [:yellow_heart:](https://our.intern.facebook.com/intern/diff/D9977505/) :white_circle: #11902 Refactor fastGet/fastSet for clarity, removing a null pointer check. [:yellow_heart:](https://our.intern.facebook.com/intern/diff/D9977654/) Kill it with fire Pull Request resolved: pytorch/pytorch#11900 Differential Revision: D9979779 Pulled By: ezyang fbshipit-source-id: 0a437e7a0baadb6440e7dc39a01b4a406171faa7
iotamudelta
pushed a commit
to ROCm/pytorch
that referenced
this pull request
Sep 21, 2018
Summary: Stack: :black_circle: **pytorch#11900 Retainable is no more** [:yellow_heart:](https://our.intern.facebook.com/intern/diff/D9977505/) :white_circle: pytorch#11902 Refactor fastGet/fastSet for clarity, removing a null pointer check. [:yellow_heart:](https://our.intern.facebook.com/intern/diff/D9977654/) Kill it with fire Pull Request resolved: pytorch#11900 Differential Revision: D9979779 Pulled By: ezyang fbshipit-source-id: 0a437e7a0baadb6440e7dc39a01b4a406171faa7
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack:
:black_circle: #11900 Retainable is no more 💛
:white_circle: #11902 Refactor fastGet/fastSet for clarity, removing a null pointer check. 💛
Kill it with fire
Differential Revision: D9977505