Specialize ArgumentSpecs on tuple elements too #11863
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apaszke
requested review from
colesbury,
ezyang,
gchanan,
soumith and
zdevito
as code owners
zdevito
approved these changes
Sep 20, 2018
Contributor
zdevito
left a comment
zdevito
left a comment
There was a problem hiding this comment.
This looks good. A few nits.
| size_t hashCode() const { | ||
| return hash_code; | ||
| } | ||
| std::vector<TypePtr> getTypes(Graph& graph) const { |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
torch/csrc/jit/type.h
Outdated
|
|
||
| struct UndefinedTensorType; | ||
| using UndefinedTensorTypePtr = std::shared_ptr<UndefinedTensorType>; | ||
| // This node represents a single Tensor value with a specific size |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
torch/csrc/jit/type.h
Outdated
| return rhs.kind() == kind(); | ||
| } | ||
| bool isSubtypeOf(const TypePtr rhs) const override { | ||
| if (rhs->kind() == TypeKind::DynamicType) |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
Contributor
facebook-github-bot
left a comment
facebook-github-bot
left a comment
There was a problem hiding this comment.
apaszke has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is pretty important because a common situation of passing LSTM hidden states as a tuple completely trashes performance of a network.
Cleans up all our propagation/undef specialization passes, at a cost of increased complexity of
ArgumentSpecandGraphExecutor. An alternative would be to simply flatten all tuple inputs to a graph ahead of time, but that might just end up being confusing in the future (you never know if you're working with a graph that can have tuple or not).