[FindCUDA] Workaround CUDA logging on some embedded platforms #11851
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
facebook-github-bot
left a comment
facebook-github-bot
left a comment
There was a problem hiding this comment.
soumith is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
zdevito
pushed a commit
to zdevito/ATen
that referenced
this pull request
Sep 20, 2018
Summary: Fixes #11518 Upstream PR submitted at https://gitlab.kitware.com/cmake/cmake/merge_requests/2400 On some embedded platforms, the NVIDIA driver is verbose logging unexpected output to stdout. One example is Drive PX2, where we see something like this whenever a CUDA program is run: ``` nvrm_gpu: Bug 200215060 workaround enabled. ``` This patch does a regex on the output of the architecture detection program to only capture architecture patterns. It's more robust than before, but not fool-proof. Pull Request resolved: pytorch/pytorch#11851 Differential Revision: D9968362 Pulled By: soumith fbshipit-source-id: b7952a87132ab05c724b287b76de263f1f671a0e
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #11518
Upstream PR submitted at https://gitlab.kitware.com/cmake/cmake/merge_requests/2400
On some embedded platforms, the NVIDIA driver is verbose logging unexpected output to stdout.
One example is Drive PX2, where we see something like this whenever a CUDA program is run:
This patch does a regex on the output of the architecture detection program to only capture architecture patterns.
It's more robust than before, but not fool-proof.