Skip to content

Comments

[ONNX] Skip empty input test case in aten_mm#118413

Closed
titaiwangms wants to merge 2 commits intopytorch:mainfrom
titaiwangms:titaiwang/skip_empty_input_in_matmul
Closed

[ONNX] Skip empty input test case in aten_mm#118413
titaiwangms wants to merge 2 commits intopytorch:mainfrom
titaiwangms:titaiwang/skip_empty_input_in_matmul

Conversation

@titaiwangms
Copy link
Collaborator

Fixes #117718
Fixes #117725

It's actually a known issue in microsoft/onnxscript#586, and we do exclude the empty input test cases in aten_matmul. This PR follows the skip, and add aten_mm as well.

@pytorch-bot
Copy link

pytorch-bot bot commented Jan 26, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/118413

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure

As of commit 962acee with merge base 2842d3c (image):

NEW FAILURE - The following job has failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added the topic: not user facing topic category label Jan 26, 2024
@titaiwangms titaiwangms added module: onnx Related to torch.onnx release notes: onnx torch.onnx related changes that should show up in the release notes labels Jan 26, 2024
@titaiwangms
Copy link
Collaborator Author

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Jan 26, 2024
@thiagocrepaldi
Copy link
Collaborator

@titaiwangms the merge will fail because of a broken CI check: Check mergeability of ghstack PR / ghstack-mergeability-check (pull_request) Failing after 3s

We have to wait for all CI checks are green and do a merge -f afterwards

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: 1 jobs have failed, first few of them are: Check mergeability and dependencies for ghstack prs / ghstack-mergeability-check

Details for Dev Infra team Raised by workflow job

@thiagocrepaldi
Copy link
Collaborator

@pytorchbot merge -f "Check mergeability of ghstack PR / ghstack-mergeability-check (pull_request) is flaky"

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@titaiwangms
Copy link
Collaborator Author

@pytorchbot merge -f "Check mergeability of ghstack PR / ghstack-mergeability-check (pull_request) is flaky"

Thanks!

jeffdaily pushed a commit to ROCm/pytorch that referenced this pull request Feb 8, 2024
Fixes pytorch#117718
Fixes pytorch#117725

It's actually a known issue in microsoft/onnxscript#586, and we do exclude the empty input test cases in aten_matmul. This PR follows the skip, and add aten_mm as well.

Pull Request resolved: pytorch#118413
Approved by: https://github.com/thiagocrepaldi
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/trunk Trigger trunk jobs on your pull request Merged module: onnx Related to torch.onnx open source release notes: onnx torch.onnx related changes that should show up in the release notes topic: not user facing topic category

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

DISABLED test_output_match_mm_cpu_float16 (__main__.TORCH_NN_MODULECPU) DISABLED test_output_match_mm_cpu_float32 (__main__.TORCH_NN_MODULECPU)

4 participants