Move blob serialization to free functions #11817
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Differential Revision: D9623916 Differential Version: 56705898
Differential Revision: D9623916 Differential Version: 56858422
Differential Revision: D9644700 Differential Version: 56870160
Differential Revision: D9623916 Differential Version: 56900314
Differential Revision: D9644700 Differential Version: 56900331
Differential Revision: D9652088 Differential Version: 56917655
Differential Revision: D9652088 Differential Version: 56918713
Differential Revision: D9652089 Differential Version: 56918714
Differential Revision: D9623916 Differential Version: 56982469
Differential Revision: D9644700 Differential Version: 56982494
Differential Revision: D9652088 Differential Version: 56982465
Differential Revision: D9652089 Differential Version: 56982470
Differential Revision: D9663476 Differential Version: 56982467
Differential Revision: D9623916 Differential Version: 57101548
Differential Revision: D9644700 Differential Version: 57101652
Differential Revision: D9652088 Differential Version: 57101545
Differential Revision: D9652089 Differential Version: 57101550
Differential Revision: D9663476 Differential Version: 57101556
Differential Revision: D9623916 Differential Version: 57135223
Differential Revision: D9644700 Differential Version: 57135224
Differential Revision: D9652088 Differential Version: 57135218
Differential Revision: D9652089 Differential Version: 57135219
Differential Revision: D9663476 Differential Version: 57135226
Differential Revision: D9694327 Differential Version: 57135227
Differential Revision: D9694326 Differential Version: 57135216
Differential Revision: D9694918 Differential Version: 57140103
Differential Revision: D9623916 Differential Version: 57214033
Differential Revision: D9644700 Differential Version: 57214023
Differential Revision: D9652088 Differential Version: 57214005
Differential Revision: D9652089 Differential Version: 57214030
Differential Revision: D9694327 Differential Version: 57851523
Differential Revision: D9778042 Differential Version: 57851524
Differential Revision: D9694326 Differential Version: 57851519
Differential Revision: D9694918 Differential Version: 57851521
Differential Revision: D9728631 Differential Version: 57851525
Differential Revision: D9728631 Differential Version: 58048804
Differential Revision: D9728631 Differential Version: 58208409
Differential Revision: D9882726 Differential Version: 58208407
Differential Revision: D9728631 Differential Version: 58229960
Differential Revision: D9882726 Differential Version: 58246781
Differential Revision: D9882726 Differential Version: 58350430
ezyang
reviewed
Sep 20, 2018
| /** | ||
| * Deserializes from a string containing either BlobProto or TensorProto. If | ||
| * the deserialization fails, the content in the blob should no longer be | ||
| * trusted. |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
ezyang
approved these changes
Sep 20, 2018
Differential Revision: D9882726 Differential Version: 58458062
Differential Revision: D9882726 Differential Version: 58501793
This was referenced Sep 21, 2018
Closed
iotamudelta
pushed a commit
to ROCm/pytorch
that referenced
this pull request
Sep 21, 2018
Summary: Pull Request resolved: pytorch#11817 Blob::Serialize() and Blob::Deserialize() are now free functions SerializeBlob(), DeserializeBlob() instead. This takes away access to Blob internals from them and makes future refactorings easier. Reviewed By: ezyang Differential Revision: D9882726 fbshipit-source-id: 3251ebd4b53fc12f5e6924a6e4a8db3846ab3729
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack:
:black_circle: #11817 Move blob serialization to free functions 💚
:white_circle: #11923 [wip] Removing some dependency edges from Blob to other caffe2 💛
:white_circle: #11924 Move Blob to ATen/core 💛
:white_circle: #11414 IValue can store Blob 💚
:white_circle: #11548 Blob doesn't allow access to destroyCall anymore 💚
:white_circle: #11500 Use TypeMeta::dtor() instead of Blob::DestroyCall 💛
:white_circle: #11925 Serialization takes pointers instead of Blob 💛
:white_circle: #11926 Remove Blob::ShareExternal from serialization 💛
Blob::Serialize() and Blob::Deserialize() are now free functions SerializeBlob(), DeserializeBlob() instead.
This takes away access to Blob internals from them and makes future refactorings easier.
Differential Revision: D9882726