Replace float16 with at::Half in caffe2 #11785

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Closed

li-roy wants to merge 2 commits into pytorch:master from li-roy:export-D9892158

Contributor

li-roy commented Sep 18, 2018 •

edited

Loading

Summary: The first commit uses at::Half as a replacement for caffe2::float16. float16 conversions and arithmetic removed to make use of Half equivalents. Also, as a side effect, aten_op works for gpu half now.

The second commit is a codemod (caffe2::float16 -> at::Half). Notable changes: caffe2/perfkernels/embedding_lookup.cc, the macro was changed because at::Half can't be in a function name. Same thing for the codegen in hp_emblookup_codegen.py.

Differential Revision: D9892158

pytorchbot added the caffe2 label

Contributor

ezyang commented Sep 18, 2018

Errr, this wasn't just a simple codemod, was it? Can we have a billing of changes?

ezyang reviewed

View reviewed changes

caffe2/perfkernels/embedding_lookup.cc Outdated

This comment was marked as off-topic.

Sign in to view

This comment was marked as off-topic.

Sign in to view

ezyang reviewed

View reviewed changes

caffe2/perfkernels/embedding_lookup.cc Outdated

This comment was marked as off-topic.

Sign in to view

This comment was marked as off-topic.

Sign in to view

ezyang reviewed

View reviewed changes

caffe2/python/examples/resnet50_trainer.py Outdated

This comment was marked as off-topic.

Sign in to view

This comment was marked as off-topic.

Sign in to view

ezyang reviewed

View reviewed changes

caffe2/python/helpers/conv.py Outdated

This comment was marked as off-topic.

Sign in to view

ezyang reviewed

View reviewed changes

caffe2/python/helpers/fc.py Outdated

This comment was marked as off-topic.

Sign in to view

ezyang reviewed

View reviewed changes

caffe2/sgd/adadelta_op_gpu.cu Outdated

This comment was marked as off-topic.

Sign in to view

ezyang reviewed

View reviewed changes

caffe2/utils/conversions.h Outdated

This comment was marked as off-topic.

Sign in to view

ezyang reviewed

View reviewed changes

Contributor

ezyang left a comment

I'm mostly a little concerned about Python side BC-breaking changes.

Contributor Author

li-roy commented Sep 18, 2018

Yeah, I'll put out a list of changes tomorrow, just wanted to start running tests tonight.

li-roy force-pushed the export-D9892158 branch from cf6fcba to f83f203 Compare

September 18, 2018 08:51

li-roy changed the title ~~codemod: caffe::float16 -> at::Half~~ Replace float16 with at::Half in caffe2

li-roy mentioned this pull request

Replace float16 with at::Half in caffe2 #11676

Closed

gchanan reviewed

View reviewed changes

aten/src/ATen/core/typeid.h Outdated

This comment was marked as off-topic.

Sign in to view

This comment was marked as off-topic.

Sign in to view

gchanan reviewed

View reviewed changes

caffe2/operators/fully_connected_op_gpu.cc Outdated Show resolved Hide resolved

caffe2/python/examples/resnet50_trainer.py Outdated

This comment was marked as off-topic.

Sign in to view

li-roy force-pushed the export-D9892158 branch from f83f203 to aa50d10 Compare

September 18, 2018 18:14

Contributor Author

li-roy commented Sep 18, 2018

@pytorchbot retest this please.

ezyang approved these changes

View reviewed changes

li-roy force-pushed the export-D9892158 branch from aa50d10 to 050e9b9 Compare

September 20, 2018 19:24

Roy Li and others added 2 commits

September 20, 2018 14:02


          Replace float16 with at::Half in caffe2 (pytorch#11676)

de36808

Summary:
- Finishes unifying Half type in pytorch and caffe2
- As a side effect, aten_op works for fp16 now
Pull Request resolved: pytorch#11676

Differential Revision: D9829019

fbshipit-source-id: e5f800024478c2e68ef29f4c06b4f0002f81a3f7


          codemod: caffe::float16 -> at::Half (pytorch#11785)

8e5dccc

Summary:
Pull Request resolved: pytorch#11785

Replace each instead of float16 with Half.

Reviewed By: Yangqing

Differential Revision: D9892158

fbshipit-source-id: c1f8dd9233423786b4a129569d4df2d39babd58e

li-roy force-pushed the export-D9892158 branch from 050e9b9 to 8e5dccc Compare

September 20, 2018 21:02

facebook-github-bot closed this in

30521a3

iotamudelta pushed a commit to ROCm/pytorch that referenced this pull request


          codemod: caffe::float16 -> at::Half (pytorch#11785)

3c15cba

Summary:
Pull Request resolved: pytorch#11785

Replace each instead of float16 with Half.

Reviewed By: Yangqing

Differential Revision: D9892158

fbshipit-source-id: b9225ca7bd5c84fd1c04a9d24b026c8b6cbff120

ezyang added the merged label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels