Skip to content

Add compilable and capturable foreach adamax with tests #117835

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
mlazos wants to merge 9 commits into from
Closed

Add compilable and capturable foreach adamax with tests #117835

mlazos wants to merge 9 commits into from

Conversation

@mlazos
Copy link
Contributor

@mlazos mlazos commented Jan 19, 2024 •
edited by pytorch-bot bot
Loading

@pytorch-bot
Copy link

pytorch-bot bot commented Jan 19, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/117835

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (3 Unrelated Failures)

As of commit c1e6d17 with merge base 414a1fd (image):

FLAKY - The following jobs failed but were likely due to flakiness present on trunk:

UNSTABLE - The following job failed but was likely due to flakiness present on trunk and has been marked as unstable:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@mlazos mlazos mentioned this pull request Jan 19, 2024
Closed
@mlazos mlazos added release notes: dynamo module: pt2 optimizer Relating to torch.compile'd optim ciflow/trunk Trigger trunk jobs on your pull request labels Jan 19, 2024
@mlazos mlazos mentioned this pull request Jan 19, 2024
Closed
janeyx99
janeyx99 reviewed Jan 19, 2024
View reviewed changes
janeyx99
janeyx99 reviewed Jan 19, 2024
View reviewed changes
janeyx99
janeyx99 reviewed Jan 19, 2024
View reviewed changes
janeyx99
janeyx99 reviewed Jan 19, 2024
View reviewed changes
janeyx99
janeyx99 reviewed Jan 19, 2024
View reviewed changes
Copy link
Contributor

@janeyx99 janeyx99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, left some review but overall p good!

janeyx99
janeyx99 reviewed Jan 19, 2024
View reviewed changes
Copy link
Contributor

@janeyx99 janeyx99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, could you point to/show the logs for the new compiled Adamax tests when you get a chance?

@mlazos
Copy link
Contributor Author

mlazos commented Jan 19, 2024

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Jan 19, 2024

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Jan 19, 2024

Merge failed

Reason: 1 mandatory check(s) failed. The first few are:

Dig deeper by viewing the failures on hud

Details for Dev Infra team Raised by workflow job

Failing merge rule: Core Maintainers

@mlazos
Copy link
Contributor Author

mlazos commented Jan 19, 2024

@pytorchbot merge

@mlazos
Copy link
Contributor Author

mlazos commented Jan 19, 2024

Nice, could you point to/show the logs for the new compiled Adamax tests when you get a chance?

https://gist.github.com/mlazos/4006518fa77897a9e67a6a2364e55212

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Jan 19, 2024

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Jan 20, 2024

The merge job was canceled. If you believe this is a mistake, then you can re trigger it through pytorch-bot.

@mlazos
Copy link
Contributor Author

mlazos commented Jan 20, 2024

@pytorchbot merge

@pytorch pytorch deleted a comment from pytorchmergebot Jan 20, 2024
@mlazos
Copy link
Contributor Author

mlazos commented Jan 20, 2024

@pytorchbot merge -f "Windows build timing out, unrelated"

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Jan 20, 2024

The merge job was canceled. If you believe this is a mistake, then you can re trigger it through pytorch-bot.

@mlazos
Copy link
Contributor Author

mlazos commented Jan 20, 2024

@pytorchbot merge -f "Windows build timing out, unrelated"

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Jan 20, 2024

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@janeyx99
Copy link
Contributor

janeyx99 commented Feb 5, 2024 •
edited
Loading

Would like to call out that this change led to eager speedup with using _foreach_maximum:
image

The most extreme of these is a 5+x speedup for DALLE2_pytorch going from ~0.118 -> ~0.020.

@github-actions github-actions bot deleted the mlazos/compiled-adamax branch March 7, 2024 01:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@janeyx99 janeyx99 janeyx99 approved these changes

@albanD albanD Awaiting requested review from albanD albanD is a code owner

Assignees

No one assigned

Labels

ciflow/inductor ciflow/trunk Trigger trunk jobs on your pull request Merged module: dynamo module: inductor module: pt2 optimizer Relating to torch.compile'd optim release notes: dynamo release notes: optim

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Support full graph compilation of foreach Adamax

4 participants

@mlazos @pytorchmergebot @janeyx99