Add env:// rendezvous test #11782
Closed
Add env:// rendezvous test #11782
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
soumith
reviewed
Sep 18, 2018
pietern
force-pushed
the
export-D9888962
branch
from
a5ccdf5 to
f88096e
Compare
apaszke
approved these changes
Sep 19, 2018
Contributor
facebook-github-bot
left a comment
facebook-github-bot
left a comment
There was a problem hiding this comment.
pietern is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Summary: A missing environment variable raised a missing key error. Now it raises a more descriptive error of the actual problem, for example: ValueError: Error initializing torch.distributed using env:// rendezvous: environment variable WORLD_SIZE expected, but not set Pull Request resolved: pytorch#11782 Differential Revision: D9888962 fbshipit-source-id: 1134175e30c123043328c9bccff1ad73c9e19ce1
pietern
force-pushed
the
export-D9888962
branch
from
f88096e to
d5d3239
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
A missing environment variable raised a missing key error. Now it
raises a more descriptive error of the actual problem, for example:
ValueError: env:// rendezvous: WORLD_SIZE not set
Differential Revision: D9888962