fix half grad assignment #11781
Closed
fix half grad assignment #11781
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ngimel
requested review from
apaszke,
colesbury,
ezyang,
gchanan,
soumith and
zdevito
as code owners
ezyang
reviewed
Sep 18, 2018
| bool gradIsSparse = false; | ||
| if (grad.type().scalarType() != at::kHalf) { | ||
| auto& sparseType = var.type().toBackend(var.is_cuda() ? Backend::SparseCUDA : Backend::SparseCPU); | ||
| gradIsSparse = grad.type() == sparseType; |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
ezyang
approved these changes
Sep 18, 2018
Contributor
ezyang
left a comment
ezyang
left a comment
There was a problem hiding this comment.
If you want me to merge this I'm OK, but I think my preferred solution would be a smidge more robust to an eventual future where we do have half-precision sparse tensors.
Maybe you can construct a at::getVariableTypeOpt call from scratch, and then just test if the pointer is null or not, as a more robust patch.
Collaborator
Author
|
@ezyang can this go in? |
Contributor
facebook-github-bot
left a comment
facebook-github-bot
left a comment
There was a problem hiding this comment.
soumith is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
currently grad assignment for half type fails with a misleading RuntimeError