[PyTorch] Add IValue::IValue(std::vector<T>&&) ctors #117769
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are two IValue constructors that take `const std::vector<T>&`. Add moving variants to allow callers to save on reference counting. Differential Revision: [D52879065](https://our.internmc.facebook.com/intern/diff/D52879065/) [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/117769
Note: Links to docs will display an error until the docs builds have been completed. ✅ You can merge normally! (6 Unrelated Failures)As of commit 527d50a with merge base 1462d72 ( FLAKY - The following jobs failed but were likely due to flakiness present on trunk:
UNSTABLE - The following job failed but was likely due to flakiness present on trunk and has been marked as unstable:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
There are two IValue constructors that take `const std::vector<T>&`. Add moving variants to allow callers to save on reference counting. Differential Revision: [D52879065](https://our.internmc.facebook.com/intern/diff/D52879065/) [ghstack-poisoned]
…&) ctors" There are two IValue constructors that take `const std::vector<T>&`. Add moving variants to allow callers to save on reference counting. Differential Revision: [D52879065](https://our.internmc.facebook.com/intern/diff/D52879065/) [ghstack-poisoned]
swolchok
added a commit
that referenced
this pull request
Jan 18, 2024
Pull Request resolved: #117769 There are two IValue constructors that take `const std::vector<T>&`. Add moving variants to allow callers to save on reference counting. ghstack-source-id: 212424719 @exported-using-ghexport Differential Revision: [D52879065](https://our.internmc.facebook.com/intern/diff/D52879065/)
Contributor
Author
|
@pytorchbot rebase |
Collaborator
|
@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here |
There are two IValue constructors that take `const std::vector<T>&`. Add moving variants to allow callers to save on reference counting. Differential Revision: [D52879065](https://our.internmc.facebook.com/intern/diff/D52879065/) [ghstack-poisoned]
Collaborator
|
Successfully rebased |
There are two IValue constructors that take `const std::vector<T>&`. Add moving variants to allow callers to save on reference counting. Differential Revision: [D52879065](https://our.internmc.facebook.com/intern/diff/D52879065/) [ghstack-poisoned]
swolchok
added a commit
that referenced
this pull request
Jan 19, 2024
Pull Request resolved: #117769 There are two IValue constructors that take `const std::vector<T>&`. Add moving variants to allow callers to save on reference counting. ghstack-source-id: 212476560 @exported-using-ghexport Differential Revision: [D52879065](https://our.internmc.facebook.com/intern/diff/D52879065/)
Skylion007
approved these changes
Jan 19, 2024
Contributor
Author
|
@pytorchbot merge |
Collaborator
Merge failedReason: This PR needs a If not, please add the To add a label, you can comment to pytorchbot, for example For more information, see Details for Dev Infra teamRaised by workflow job |
Contributor
Author
|
@pytorchbot merge |
Collaborator
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
There are two IValue constructors that take
const std::vector<T>&. Add moving variants to allow callers to save on reference counting.Differential Revision: D52879065