[HigherOrderOp] change signature of map_impl #117161

ydwu4 · 2024-01-10T21:51:22Z

Summary:
X-link: pytorch/executorch#1580

This PR changes the schema of map_impl from map_impl(f, num_mapped, *operands) to map_impl(f, mapped_args: Tuple, moperands: Tuple). This is to prepare for turning on dynamo for eager mode map, where we want to get rid of the num_mapped scalar.

Test Plan: Existing tests.

Differential Revision: D52495413

cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @chenyang78 @aakhundov @kadeng

pytorch-bot · 2024-01-10T21:51:25Z

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/117161

📄 Preview Python docs built from this PR
📄 Preview C++ docs built from this PR
❓ Need help or want to give feedback on the CI? Visit the bot commands wiki or our office hours

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit db4dd26 with merge base 21d3708 ():
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

facebook-github-bot · 2024-01-10T21:51:31Z

This pull request was exported from Phabricator. Differential Revision: D52495413

github-actions · 2024-01-10T21:53:05Z

This PR needs a `release notes:` label

If your changes are user facing and intended to be a part of release notes, please use a label starting with release notes:.

If not, please add the topic: not user facing label.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "topic: not user facing"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

facebook-github-bot · 2024-01-11T17:39:40Z

This pull request was exported from Phabricator. Differential Revision: D52495413

Summary: X-link: pytorch/pytorch#117161 This PR changes the schema of map_impl from map_impl(f, num_mapped, *operands) to map_impl(f, mapped_args: Tuple, moperands: Tuple). This is to prepare for turning on dynamo for eager mode cond, where we want to get rid of the num_mapped scalar. Reviewed By: angelayi Differential Revision: D52495413

facebook-github-bot · 2024-01-11T17:41:05Z

This pull request was exported from Phabricator. Differential Revision: D52495413

facebook-github-bot · 2024-01-11T19:41:55Z

This pull request was exported from Phabricator. Differential Revision: D52495413

Summary: X-link: pytorch/pytorch#117161 This PR changes the schema of map_impl from map_impl(f, num_mapped, *operands) to map_impl(f, mapped_args: Tuple, moperands: Tuple). This is to prepare for turning on dynamo for eager mode cond, where we want to get rid of the num_mapped scalar. Reviewed By: angelayi Differential Revision: D52495413

facebook-github-bot · 2024-01-11T19:42:52Z

This pull request was exported from Phabricator. Differential Revision: D52495413

facebook-github-bot · 2024-01-11T23:18:42Z

This pull request was exported from Phabricator. Differential Revision: D52495413

Summary: X-link: pytorch/pytorch#117161 This PR changes the schema of map_impl from map_impl(f, num_mapped, *operands) to map_impl(f, mapped_args: Tuple, moperands: Tuple). This is to prepare for turning on dynamo for eager mode map, where we want to get rid of the num_mapped scalar. Reviewed By: angelayi Differential Revision: D52495413

facebook-github-bot · 2024-01-11T23:19:44Z

This pull request was exported from Phabricator. Differential Revision: D52495413

Summary: X-link: pytorch/executorch#1580 This PR changes the schema of map_impl from map_impl(f, num_mapped, *operands) to map_impl(f, mapped_args: Tuple, moperands: Tuple). This is to prepare for turning on dynamo for eager mode map, where we want to get rid of the num_mapped scalar. Test Plan: Existing tests. Reviewed By: angelayi Differential Revision: D52495413

Summary: X-link: pytorch/pytorch#117161 This PR changes the schema of map_impl from map_impl(f, num_mapped, *operands) to map_impl(f, mapped_args: Tuple, moperands: Tuple). This is to prepare for turning on dynamo for eager mode map, where we want to get rid of the num_mapped scalar. Reviewed By: angelayi Differential Revision: D52495413

facebook-github-bot · 2024-01-12T17:25:24Z

This pull request was exported from Phabricator. Differential Revision: D52495413

facebook-github-bot · 2024-01-12T17:25:34Z

This pull request was exported from Phabricator. Differential Revision: D52495413

Summary: X-link: pytorch/pytorch#117161 Pull Request resolved: #1580 This PR changes the schema of map_impl from map_impl(f, num_mapped, *operands) to map_impl(f, mapped_args: Tuple, moperands: Tuple). This is to prepare for turning on dynamo for eager mode map, where we want to get rid of the num_mapped scalar. Reviewed By: angelayi Differential Revision: D52495413 fbshipit-source-id: 3f99074d3ab4a8badae3cc72e7422482837e255a

facebook-github-bot · 2024-01-13T02:48:42Z

@pytorchbot merge -f 'Landed internally'

(Initiating merge automatically since Phabricator Diff has merged, using force because this PR might not pass merge_rules.json but landed internally)

pytorchmergebot · 2024-01-13T02:50:35Z

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

…ve on specific old versions of gcc

…mv8-a+sve on specific old versions of gcc

ydwu4 requested review from avikchaudhuri, gmagogsfm, tugsbayasgalan and zhxchen17 as code owners January 10, 2024 21:51

facebook-github-bot added the fb-exported label Jan 10, 2024

github-actions bot added module: dynamo ciflow/inductor labels Jan 10, 2024

angelayi approved these changes Jan 10, 2024

View reviewed changes

pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Jan 10, 2024

ydwu4 force-pushed the export-D52495413 branch from 9169cca to 04eb59c Compare January 11, 2024 17:39

ydwu4 force-pushed the export-D52495413 branch from 04eb59c to 8195f86 Compare January 11, 2024 17:40

ydwu4 force-pushed the export-D52495413 branch from 8195f86 to d37dcc9 Compare January 11, 2024 19:41

ydwu4 force-pushed the export-D52495413 branch from d37dcc9 to 947bb6d Compare January 11, 2024 19:42

tugsbayasgalan approved these changes Jan 11, 2024

View reviewed changes

ydwu4 force-pushed the export-D52495413 branch from 947bb6d to 405bd7c Compare January 11, 2024 23:18

ydwu4 force-pushed the export-D52495413 branch from 405bd7c to b325f92 Compare January 11, 2024 23:19

ydwu4 force-pushed the export-D52495413 branch from b325f92 to 5ad9bf7 Compare January 12, 2024 17:25

ydwu4 force-pushed the export-D52495413 branch from 5ad9bf7 to db4dd26 Compare January 12, 2024 17:25

pytorchmergebot added the merging label Jan 13, 2024

pytorchmergebot closed this in 2bc7da1 Jan 13, 2024

pytorchmergebot added Merged and removed merging labels Jan 13, 2024

pytorch-bot bot pushed a commit that referenced this pull request Oct 28, 2024

workaround for gcc bug #117161 to prevent compiler error in armv8-a+s…

f3dc20c

…ve on specific old versions of gcc

pytorch-bot bot pushed a commit that referenced this pull request Nov 5, 2024

workaround for gcc bug #117161 to prevent compiler error in armv8-a+s…

c673ab0

…ve on specific old versions of gcc

pytorchmergebot pushed a commit to robert-hardwick/pytorch that referenced this pull request Nov 5, 2024

workaround for gcc bug pytorch#117161 to prevent compiler error in ar…

5628514

…mv8-a+sve on specific old versions of gcc

[HigherOrderOp] change signature of map_impl #117161

[HigherOrderOp] change signature of map_impl #117161

Uh oh!

Conversation

ydwu4 commented Jan 10, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pytorch-bot bot commented Jan 10, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/117161

✅ No Failures

Uh oh!

facebook-github-bot commented Jan 10, 2024

Uh oh!

github-actions bot commented Jan 10, 2024

This PR needs a release notes: label

Uh oh!

facebook-github-bot commented Jan 11, 2024

Uh oh!

facebook-github-bot commented Jan 11, 2024

Uh oh!

facebook-github-bot commented Jan 11, 2024

Uh oh!

facebook-github-bot commented Jan 11, 2024

Uh oh!

facebook-github-bot commented Jan 11, 2024

Uh oh!

facebook-github-bot commented Jan 11, 2024

Uh oh!

facebook-github-bot commented Jan 12, 2024

Uh oh!

facebook-github-bot commented Jan 12, 2024

Uh oh!

facebook-github-bot commented Jan 13, 2024

Uh oh!

pytorchmergebot commented Jan 13, 2024

Merge started

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

ydwu4 commented Jan 10, 2024 •

edited

Loading

pytorch-bot bot commented Jan 10, 2024 •

edited

Loading

This PR needs a `release notes:` label