[pt1][tensor] Move CreateContext to global registry #11688
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Differential Revision: D9779821 Differential Version: 57806436
jerryzh168
requested review from
apaszke,
colesbury,
ezyang,
gchanan,
soumith and
zdevito
as code owners
Differential Revision: D9779821 Differential Version: 58713403
Differential Revision: D9779821 Differential Version: 58748651
zdevito
pushed a commit
to zdevito/ATen
that referenced
this pull request
Sep 25, 2018
Summary: Pull Request resolved: pytorch/pytorch#11688 As a first step to remove static context(merge with allocator), we'll create a global registries for context constructors, and remove CreateContext function from tensor. Reviewed By: ezyang, dzhulgakov Differential Revision: D9779821 fbshipit-source-id: 8b239ea50af7a0556fde2382f58f79194f0e3dc1
ezyang
added a commit
to ezyang/pytorch
that referenced
this pull request
Sep 25, 2018
This reverts commit 3ae6ee4.
facebook-github-bot
pushed a commit
that referenced
this pull request
Sep 25, 2018
This was referenced Sep 25, 2018
jerryzh168
added a commit
to jerryzh168/pytorch
that referenced
this pull request
Sep 28, 2018
…pytorch#11688)"" (pytorch#12121) Summary: Pull Request resolved: pytorch#12121 Pull Request resolved: pytorch#12055 Original commit changeset: 6ca9de65b707 Reviewed By: ezyang Differential Revision: D10033396 fbshipit-source-id: 0936ccbeae529119586e41dd1a687f5ef1f85c8f
wanchaol
pushed a commit
to wanchaol/pytorch
that referenced
this pull request
Oct 1, 2018
…pytorch#11688)"" (pytorch#12121) Summary: Pull Request resolved: pytorch#12121 Pull Request resolved: pytorch#12055 Original commit changeset: 6ca9de65b707 Reviewed By: ezyang Differential Revision: D10033396 fbshipit-source-id: ca9f4b2f7ef0561f619b833415d394a8b9972bf4
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack:
:black_circle: #11688 [pt1][tensor] Move CreateContext to global registry 💛
:white_circle: #12029 [pt1][tensor] New in StaticContext returns at::DataPtr 💛
As a first step to remove static context(merge with allocator), we'll create a
global registries for context constructors, and remove CreateContext function from tensor.
Differential Revision: D9779821