Skip to content

Conversation

@PenghuiCheng
Copy link
Contributor

No description provided.

@PenghuiCheng
Copy link
Contributor Author

@wesolwsk,Please review the commit.
Thanks!

@wesolwsk
Copy link
Contributor

You are getting a tensor uninitialized error in data_parallel_model_test.RecurrentNetworkParallelTest.test_equiv_recurrent. Can you take a look?

@PenghuiCheng
Copy link
Contributor Author

From log,the issue seems on device_option { device_type: 0 cuda_gpu_id: 3 },but my patch is for ideep only,It is weird.

@wesolwsk
Copy link
Contributor

cuda_gpu_id indicates the id of the model copy on a node within a DPM instance. It is used for both CPU and GPU runs and should be renamed to something like device_id to avoid this confusion. Here, device_type 0 indicates CPU is being used.

Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wesolwsk has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@wesolwsk
Copy link
Contributor

@PenghuiCheng - could you please rebase

@PenghuiCheng
Copy link
Contributor Author

@wesolwsk ,had rebased.
Thanks!

Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wesolwsk has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants