Update torch.autograd.graph logging to not print out grad_output #116523
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/116523
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 5257e6b with merge base e5f2ac1 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
albanD
approved these changes
Dec 30, 2023
torch/autograd/graph.py
Outdated
| def prehook(grad_output): | ||
| node = torch._C._current_autograd_node() | ||
| log_str = f"Executing: {node} with grad_output: {grad_output}" | ||
| log_str = f"Executing: {node}" |
Collaborator
There was a problem hiding this comment.
If this is too verbose, feel free to only print size to share some information.
…output" [ghstack-poisoned]
albanD
reviewed
Jan 3, 2024
|
|
||
| if t is None: | ||
| return "None" | ||
| return f"{dtype_abbrs[t.dtype]}[{', '.join(map(str, t.shape))}]" |
Collaborator
There was a problem hiding this comment.
Is that a usual format used in other places?
Contributor
Author
There was a problem hiding this comment.
Yeah, fx and logging tensor also use this format
albanD
reviewed
Jan 4, 2024
Collaborator
albanD
left a comment
albanD
left a comment
There was a problem hiding this comment.
Change sounds good but needs rebase!
albanD
approved these changes
Jan 4, 2024
…output" Instead of printing the tensor's data print the dtype and shape metadata of the tensor. ``` Executing: <VarMeanBackward0 object at 0x1352d0e20> with grad_outputs: [None,f32[]] ``` This is important in order to avoid doing a cuda sync and also useful to reduce verbosity. [ghstack-poisoned]
…output" Instead of printing the tensor's data print the dtype and shape metadata of the tensor. ``` Executing: <VarMeanBackward0 object at 0x1352d0e20> with grad_outputs: [None,f32[]] ``` This is important in order to avoid doing a cuda sync and also useful to reduce verbosity. [ghstack-poisoned]
…output" Instead of printing the tensor's data print the dtype and shape metadata of the tensor. ``` Executing: <VarMeanBackward0 object at 0x1352d0e20> with grad_outputs: [None,f32[]] ``` This is important in order to avoid doing a cuda sync and also useful to reduce verbosity. [ghstack-poisoned]
Contributor
Author
|
@pytorchbot merge |
Collaborator
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
pytorchmergebot
pushed a commit
that referenced
this pull request
Jan 9, 2024
…d clarify docs (#116710) Pull Request resolved: #116710 Approved by: https://github.com/albanD ghstack dependencies: #116523
xadupre
pushed a commit
to xadupre/pytorch
that referenced
this pull request
Jan 10, 2024
…orch#116523) Instead of printing the tensor's data print the dtype and shape metadata of the tensor. ``` Executing: <VarMeanBackward0 object at 0x1352d0e20> with grad_outputs: [None,f32[]] ``` This is important in order to avoid doing a cuda sync and also useful to reduce verbosity. Pull Request resolved: pytorch#116523 Approved by: https://github.com/albanD
xadupre
pushed a commit
to xadupre/pytorch
that referenced
this pull request
Jan 10, 2024
…d clarify docs (pytorch#116710) Pull Request resolved: pytorch#116710 Approved by: https://github.com/albanD ghstack dependencies: pytorch#116523
pytorchmergebot
pushed a commit
that referenced
this pull request
Jan 10, 2024
Fixes #116099 Pull Request resolved: #117067 Approved by: https://github.com/lezcano, https://github.com/albanD ghstack dependencies: #116523, #116710
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Instead of printing the tensor's data print the dtype and shape metadata of the tensor.
This is important in order to avoid doing a cuda sync and also useful to reduce verbosity.