[ROCm] fix nightly 5.6 build #116029

jeffdaily · 2023-12-18T17:56:46Z

ROCm 5.6 nightly wheel build broken by #114329. This fixes it.

cc @sunway513 @jithunnair-amd @pruthvistony @ROCmSupport @dllehr-amd @jataylo @hongxiayang

pytorch-bot · 2023-12-18T17:56:50Z

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/116029

📄 Preview Python docs built from this PR
📄 Preview C++ docs built from this PR
❓ Need help or want to give feedback on the CI? Visit the bot commands wiki or our office hours

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (9 Unrelated Failures)

As of commit e688d95 with merge base 1d5a9a1 ():

FLAKY - The following jobs failed but were likely due to flakiness present on trunk:

pull / linux-focal-cuda12.1-py3.10-gcc9-sm86 / test (default, 2, 5, linux.g5.4xlarge.nvidia.gpu) (gh)
dynamo/test_trace_rules.py::TraceRuleTests::test_torch_name_rule_map_updated
pull / linux-focal-py3.11-clang10 / test (dynamo, 2, 7, linux.2xlarge) (gh)
RuntimeError: nn/test_init 1/2 failed
pull / linux-focal-py3.11-clang10 / test (dynamo, 3, 7, linux.2xlarge) (gh)
RuntimeError: nn/test_init 2/2 failed
pull / linux-focal-py3.8-clang10 / test (dynamo, 2, 7, linux.2xlarge) (gh)
##[error]The operation was canceled.
pull / linux-focal-py3.8-clang10 / test (dynamo, 3, 7, linux.2xlarge) (gh)
RuntimeError: nn/test_init 2/2 failed

BROKEN TRUNK - The following jobs failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

pull / linux-focal-py3.11-clang10 / test (dynamo, 6, 7, linux.2xlarge) (gh)
functorch/test_vmap.py::TestVmapNestedTensorCPU::test_fallback_binary_cpu
pull / linux-focal-py3.11-clang10 / test (dynamo, 7, 7, linux.2xlarge) (gh)
functorch/test_vmap.py::TestVmapNestedTensorCPU::test_cat_batching_rule_cpu
pull / linux-focal-py3.8-clang10 / test (dynamo, 4, 7, linux.2xlarge) (gh)
functorch/test_vmap.py::TestVmapNestedTensorCPU::test_fallback_binary_cpu
pull / linux-focal-py3.8-clang10 / test (dynamo, 5, 7, linux.2xlarge) (gh)
functorch/test_vmap.py::TestVmapNestedTensorCPU::test_cat_batching_rule_cpu

This comment was automatically generated by Dr. CI and updates every 15 minutes.

jeffdaily · 2023-12-18T19:37:23Z

@pytorchbot merge

pytorchmergebot · 2023-12-18T19:39:16Z

Merge failed

Reason: This PR needs a release notes: label
If your changes are user facing and intended to be a part of release notes, please use a label starting with release notes:.

If not, please add the topic: not user facing label.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "topic: not user facing"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

Details for Dev Infra team

Raised by workflow job

jeffdaily · 2023-12-18T20:20:47Z

@pytorchbot merge

pytorchmergebot · 2023-12-18T20:22:58Z

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

jeanschmidt · 2023-12-19T00:59:55Z

@pytorchbot revert -m "Need to revert, in order to be able to revert #114329" -c ghfirst

pytorchmergebot · 2023-12-19T01:01:37Z

@pytorchbot successfully started a revert job. Check the current status here.
Questions? Feedback? Please reach out to the PyTorch DevX Team

pytorchmergebot · 2023-12-19T01:01:47Z

@jeffdaily your PR has been successfully reverted.

This reverts commit 63e242b. Reverted #116029 on behalf of https://github.com/jeanschmidt due to Need to revert, in order to be able to revert #114329 ([comment](#116029 (comment)))

jeffdaily · 2023-12-20T20:39:46Z

@pytorchbot rebase

pytorchmergebot · 2023-12-20T20:41:25Z

@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here

pytorchmergebot · 2023-12-20T20:41:27Z

Rebase failed due to

Aborting rebase because rebasing the branch resulted in the same sha as the target branch.
This usually happens because the PR has already been merged.  Please rebase locally and push.

Raised by https://github.com/pytorch/pytorch/actions/runs/7280554829

jeffdaily · 2023-12-20T21:03:22Z

@pytorchbot merge

pytorchmergebot · 2023-12-20T21:05:30Z

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

pytorchmergebot · 2023-12-20T22:32:31Z

Merge failed

Reason: 1 mandatory check(s) failed. The first few are:

pull / linux-focal-py3.8-clang10 / test (dynamo, 2, 7, linux.2xlarge)

Dig deeper by viewing the failures on hud

Details for Dev Infra team

Raised by workflow job

Failing merge rule: Core Maintainers

jeffdaily · 2023-12-21T00:19:39Z

@pytorchbot merge -f "unrelated unstable tests failing; rocm CI passing"

pytorchmergebot · 2023-12-21T00:22:24Z

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

ROCm 5.6 nightly wheel build broken by pytorch#114329. This fixes it. Pull Request resolved: pytorch#116029 Approved by: https://github.com/huydhn, https://github.com/jithunnair-amd, https://github.com/atalman

This reverts commit 63e242b. Reverted pytorch#116029 on behalf of https://github.com/jeanschmidt due to Need to revert, in order to be able to revert pytorch#114329 ([comment](pytorch#116029 (comment)))

jeffdaily requested review from atalman, huydhn and malfet December 18, 2023 17:56

pytorch-bot bot added the ciflow/rocm Trigger "default" config CI on ROCm label Dec 18, 2023

pytorch-bot bot added the module: rocm AMD GPU support for Pytorch label Dec 18, 2023

pytorchbot added the open source label Dec 18, 2023

huydhn approved these changes Dec 18, 2023

View reviewed changes

jithunnair-amd approved these changes Dec 18, 2023

View reviewed changes

pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Dec 18, 2023

pytorchmergebot added the merging label Dec 18, 2023

pytorchmergebot removed the merging label Dec 18, 2023

atalman approved these changes Dec 18, 2023

View reviewed changes

jeffdaily added the topic: not user facing topic category label Dec 18, 2023

pytorchmergebot added the merging label Dec 18, 2023

pytorchmergebot added Merged and removed merging labels Dec 18, 2023

pytorchmergebot closed this in 63e242b Dec 18, 2023

pytorchmergebot added the Reverted label Dec 19, 2023

pytorchmergebot reopened this Dec 19, 2023

[ROCm] fix nightly 5.6 build

e688d95

jeffdaily force-pushed the rocm_fix_nightly_56_build branch from 7b70826 to e688d95 Compare December 20, 2023 21:02

pytorchmergebot added the merging label Dec 20, 2023

pytorchmergebot removed the merging label Dec 20, 2023

pytorchmergebot added the merging label Dec 21, 2023

pytorchmergebot removed the merging label Dec 21, 2023

pytorchmergebot closed this in 8aae46f Dec 21, 2023

kit1980 removed the Reverted label Dec 21, 2023

[ROCm] fix nightly 5.6 build #116029

[ROCm] fix nightly 5.6 build #116029

Uh oh!

Conversation

jeffdaily commented Dec 18, 2023 • edited by pytorch-bot bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pytorch-bot bot commented Dec 18, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/116029

✅ You can merge normally! (9 Unrelated Failures)

Uh oh!

jeffdaily commented Dec 18, 2023

Uh oh!

pytorchmergebot commented Dec 18, 2023

Merge failed

Uh oh!

jeffdaily commented Dec 18, 2023

Uh oh!

pytorchmergebot commented Dec 18, 2023

Merge started

Uh oh!

jeanschmidt commented Dec 19, 2023

Uh oh!

pytorchmergebot commented Dec 19, 2023

Uh oh!

pytorchmergebot commented Dec 19, 2023

Uh oh!

jeffdaily commented Dec 20, 2023

Uh oh!

pytorchmergebot commented Dec 20, 2023

Uh oh!

pytorchmergebot commented Dec 20, 2023

Uh oh!

jeffdaily commented Dec 20, 2023

Uh oh!

pytorchmergebot commented Dec 20, 2023

Merge started

Uh oh!

pytorchmergebot commented Dec 20, 2023

Merge failed

Uh oh!

jeffdaily commented Dec 21, 2023

Uh oh!

pytorchmergebot commented Dec 21, 2023

Merge started

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

jeffdaily commented Dec 18, 2023 •

edited by pytorch-bot bot

Loading

pytorch-bot bot commented Dec 18, 2023 •

edited

Loading