Blob doesn't allow access to destroyCall anymore #11548
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Differential Revision: D9775191 Differential Version: 57535397
This was referenced Sep 11, 2018
Closed
Closed
Closed
Differential Revision: D9775191 Differential Version: 57551488
ezyang
approved these changes
Sep 12, 2018
ezyang
requested changes
Sep 12, 2018
Contributor
ezyang
left a comment
ezyang
left a comment
There was a problem hiding this comment.
You're not allowed to have a diff in a stack of diffs that breaks. Every diff has to continue compiling. So use site fixes need to be squashed into this diff.
Differential Revision: D9775191 Differential Version: 57670061
Contributor
Author
|
@ezyang The diffs fixing use sites had some fbcode-only diffs. I removed them from the stack because the ghexport script didn't support that yet. I'll land them separately and then rebase this stack on top of new master. |
Differential Revision: D9775191 Differential Version: 57695971
Differential Revision: D9775191 Differential Version: 57757836
Differential Revision: D9775191 Differential Version: 57851522
Differential Revision: D9775191 Differential Version: 58048806
Differential Revision: D9775191 Differential Version: 58501789
This was referenced Sep 21, 2018
ezyang
approved these changes
Sep 21, 2018
Differential Revision: D9775191 Differential Version: 58691279
Differential Revision: D9775191 Differential Version: 58749272
Differential Revision: D9775191 Differential Version: 58780866
Differential Revision: D9775191 Differential Version: 58857361
Differential Revision: D9775191 Differential Version: 58899990
Differential Revision: D9775191 Differential Version: 58901385
zdevito
pushed a commit
to zdevito/ATen
that referenced
this pull request
Sep 26, 2018
Summary: Pull Request resolved: pytorch/pytorch#11548 This removes getting/setting the DestroyCall of a Blob, paving the way to removing DestroyCall from Blob entirely and using the destructor stored in TypeMeta instead. Use sites have been fixed in diffs stacked below this. Reviewed By: dzhulgakov Differential Revision: D9775191 fbshipit-source-id: 97d72d0c62843849057f295c27f391e63c99c521
petrex
pushed a commit
to petrex/pytorch
that referenced
this pull request
Sep 26, 2018
* upstream/master: (117 commits) Add full namespace resolution in CAFFE_DURATION (pytorch#12065) T33898723: Simple put operators for caffe2 stats (pytorch#12057) add narrow() support for sparse tensors re: pytorch#8853 (pytorch#11342) Fix ONNX bug, add symbolic for full Enable tracing of tensor factories with an out argument Fix warnings emitted when testing distributions (pytorch#12038) Unify versions across setup.py, libtorch, and libcaffe2 (pytorch#12053) add autodiff expressions for common operations (pytorch#11832) Blob doesn't allow access to destroyCall anymore (pytorch#11548) IValue can store Blob (pytorch#11414) Move Blob to ATen/core (pytorch#11924) Use tempfile during serialized test comparison (pytorch#12021) fix segfault when grad to a hook fn is None (pytorch#12028) Fallback CreateMutex/AtomicIter operators for mkl-dnn Unify all *_EXPORT and *_IMPORT macros across c++ backend (pytorch#12019) Add safety asserts for methods on TensorImpl which don't work on Variable. (pytorch#12058) Make USE_IDEEP work again (pytorch#12026) Fix "identifier following the 'template' keyword does not refer to a template" (pytorch#12037) Delete some unused variables. (pytorch#12059) Support TypeIdentifier::name() (pytorch#12036) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack:
:white_circle: #11924 Move Blob to ATen/core 💚
:white_circle: #11414 IValue can store Blob 💚
:black_circle: #11548 Blob doesn't allow access to destroyCall anymore 💚
:white_circle: #11500 Use TypeMeta::dtor() instead of Blob::DestroyCall 💛
:white_circle: #11925 Serialization takes pointers instead of Blob 💛
:white_circle: #11926 Remove Blob::ShareExternal from serialization 💚
This removes getting/setting the DestroyCall of a Blob,
paving the way to removing DestroyCall from Blob entirely and using the destructor stored in TypeMeta instead.
Use sites have been fixed in diffs stacked below this.
Differential Revision: D9775191