Use TypeMeta::dtor() instead of Blob::DestroyCall #11500
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Sep 11, 2018
Closed
Closed
ezyang
approved these changes
Sep 11, 2018
smessmer
requested review from
Yangqing,
anderspapitto,
apaszke,
bddppq,
colesbury,
dzhulgakov,
ebetica,
fmassa,
gchanan,
goldsborough,
houseroad,
jamesr66a,
pietern,
soumith,
ssnl,
teng-li,
zdevito and
zou3519
as code owners
This was referenced Sep 11, 2018
Closed
Differential Revision: D9980641 Differential Version: 58899987
Differential Revision: D9731326 Differential Version: 58899983
Differential Revision: D9775191 Differential Version: 58899990
Differential Revision: D9763423 Differential Version: 58899992
Differential Revision: D9980641 Differential Version: 58901381
Differential Revision: D9731326 Differential Version: 58901379
Differential Revision: D9775191 Differential Version: 58901385
Differential Revision: D9763423 Differential Version: 58901378
Differential Revision: D9763423 Differential Version: 59384180
Yangqing
approved these changes
Oct 1, 2018
Differential Revision: D9763423 Differential Version: 59638710
This was referenced Oct 3, 2018
Differential Revision: D9763423 Differential Version: 59644402
Differential Revision: D9763423 Differential Version: 59750307
Differential Revision: D9763423 Differential Version: 59930640
Differential Revision: D9763423 Differential Version: 60109136
Differential Revision: D9763423 Differential Version: 60766875
Differential Revision: D9763423 Differential Version: 60767852
Differential Revision: D9763423 Differential Version: 60887304
zdevito
pushed a commit
to zdevito/ATen
that referenced
this pull request
Oct 17, 2018
Summary: Pull Request resolved: pytorch/pytorch#11500 Since TypeMeta already stores a destructor, and we removed the ability from Blob to store a custom destructor in a diff stacked below this, there is now no reason for Blob to store it again. Reviewed By: ezyang Differential Revision: D9763423 fbshipit-source-id: d37a792ffd6928ed1906f5ba88bd4f1d1e2b3781
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack:
:white_circle: #12307 Add TypeMeta::New/Delete 💚
:black_circle: #11500 Use TypeMeta::dtor() instead of Blob::DestroyCall 💚
:white_circle: #11925 Serialization takes pointers instead of Blob 💚
:white_circle: #11926 Remove Blob::ShareExternal from serialization 💚
Since TypeMeta already stores a destructor, and we removed the ability from Blob to store a custom destructor in a diff stacked below this, there is now no reason for Blob to store it again.
Differential Revision: D9763423