Add "merge to master" step before build in CircleCI #11443
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ezyang
reviewed
Sep 10, 2018
.circleci/config.yml
Outdated
| git fetch --tags --progress https://github.com/pytorch/pytorch.git +refs/heads/*:refs/remotes/origin/* --depth=50 --quiet | ||
| git config remote.origin.url https://github.com/pytorch/pytorch.git | ||
| git config --add remote.origin.fetch +refs/heads/*:refs/remotes/origin/* | ||
| git fetch --tags --progress https://github.com/pytorch/pytorch.git +refs/heads/*:refs/remotes/origin/* +refs/pull/*:refs/remotes/origin/pr/* --depth=50 --quiet |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
ezyang
reviewed
Sep 10, 2018
| export AWS_ACCESS_KEY_ID=AKIAJJZUW4G2ASX5W7KA | ||
| export AWS_SECRET_ACCESS_KEY=${CIRCLECI_AWS_SECRET_KEY_FOR_SCCACHE_S3_BUCKET} | ||
| git submodule update --init || git submodule update --init || git submodule update --init | ||
| git submodule sync && git submodule update --init |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
added 10 commits
September 10, 2018 14:54
ezyang
approved these changes
Sep 11, 2018
Contributor
facebook-github-bot
left a comment
facebook-github-bot
left a comment
There was a problem hiding this comment.
yf225 has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
This was referenced Mar 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the "merge to master" step before the build step in CircleCI, so that all PR commits are built against master instead of against the PR's branch. Note that all PRs still need to rebase to master to pick up this new config, so it won't apply to old PR branches retroactively.
To check in CI: make sure it's performing the git merge to master appropriately in "Merge Onto Master" step.