IValue can store Blob #11414
Closed
IValue can store Blob #11414
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Differential Revision: D9731326 Differential Version: 57268332
smessmer
requested review from
apaszke,
colesbury,
ezyang,
gchanan,
soumith and
zdevito
as code owners
This was referenced Sep 7, 2018
Closed
ezyang
approved these changes
Sep 8, 2018
Contributor
|
FYI you're still on the old, buggy version of ghexport, so the links don't work |
Differential Revision: D9731326 Differential Version: 57416729
Differential Revision: D9731326 Differential Version: 57417172
Differential Revision: D9731326 Differential Version: 57452243
This was referenced Sep 11, 2018
Closed
Differential Revision: D9731326 Differential Version: 57535404
This was referenced Sep 11, 2018
Closed
Differential Revision: D9731326 Differential Version: 57551484
dzhulgakov
reviewed
Sep 12, 2018
torch/csrc/jit/ivalue.h
Outdated
|
|
||
| IValue(caffe2::Blob blob) | ||
| : tag(Tag::Blob), is_intrusive_ptr(true) { | ||
| // TODO (after Tensor merge) If we pass in a Blob holding a Tensor, extract and |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
Differential Revision: D9731326 Differential Version: 57670070
Differential Revision: D9731326 Differential Version: 57695964
Differential Revision: D9731326 Differential Version: 57757837
Differential Revision: D9731326 Differential Version: 57851527
Differential Revision: D9731326 Differential Version: 58048809
Differential Revision: D9731326 Differential Version: 58501795
This was referenced Sep 21, 2018
This was referenced Sep 21, 2018
Differential Revision: D9731326 Differential Version: 58691281
Differential Revision: D9731326 Differential Version: 58749270
Differential Revision: D9731326 Differential Version: 58780865
Differential Revision: D9731326 Differential Version: 58857364
Differential Revision: D9731326 Differential Version: 58899983
Differential Revision: D9731326 Differential Version: 58901379
zdevito
pushed a commit
to zdevito/ATen
that referenced
this pull request
Sep 26, 2018
Summary: Pull Request resolved: pytorch/pytorch#11414 caffe2::Blob can be stored in an IValue. This is a precondition for caffe2 to switch from Blob to IValue. Reviewed By: ezyang Differential Revision: D9731326 fbshipit-source-id: 462a39d2d9ab6f85b99b1670848c6976a3de417c
petrex
pushed a commit
to petrex/pytorch
that referenced
this pull request
Sep 26, 2018
* upstream/master: (117 commits) Add full namespace resolution in CAFFE_DURATION (pytorch#12065) T33898723: Simple put operators for caffe2 stats (pytorch#12057) add narrow() support for sparse tensors re: pytorch#8853 (pytorch#11342) Fix ONNX bug, add symbolic for full Enable tracing of tensor factories with an out argument Fix warnings emitted when testing distributions (pytorch#12038) Unify versions across setup.py, libtorch, and libcaffe2 (pytorch#12053) add autodiff expressions for common operations (pytorch#11832) Blob doesn't allow access to destroyCall anymore (pytorch#11548) IValue can store Blob (pytorch#11414) Move Blob to ATen/core (pytorch#11924) Use tempfile during serialized test comparison (pytorch#12021) fix segfault when grad to a hook fn is None (pytorch#12028) Fallback CreateMutex/AtomicIter operators for mkl-dnn Unify all *_EXPORT and *_IMPORT macros across c++ backend (pytorch#12019) Add safety asserts for methods on TensorImpl which don't work on Variable. (pytorch#12058) Make USE_IDEEP work again (pytorch#12026) Fix "identifier following the 'template' keyword does not refer to a template" (pytorch#12037) Delete some unused variables. (pytorch#12059) Support TypeIdentifier::name() (pytorch#12036) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack:
:white_circle: #11924 Move Blob to ATen/core 💚
:black_circle: #11414 IValue can store Blob 💚
:white_circle: #11548 Blob doesn't allow access to destroyCall anymore 💚
:white_circle: #11500 Use TypeMeta::dtor() instead of Blob::DestroyCall 💛
:white_circle: #11925 Serialization takes pointers instead of Blob 💛
:white_circle: #11926 Remove Blob::ShareExternal from serialization 💚
caffe2::Blob can be stored in an IValue. This is a precondition for caffe2 to switch from Blob to IValue.
Differential Revision: D9731326