Simplify Blob move constructor/assignment #11402
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Differential Revision: D9623916 Differential Version: 56705898
Differential Revision: D9623916 Differential Version: 56858422
Differential Revision: D9644700 Differential Version: 56870160
Differential Revision: D9623916 Differential Version: 56900314
Differential Revision: D9644700 Differential Version: 56900331
Differential Revision: D9652088 Differential Version: 56917655
Differential Revision: D9652088 Differential Version: 56918713
Differential Revision: D9652089 Differential Version: 56918714
Differential Revision: D9623916 Differential Version: 56982469
Differential Revision: D9644700 Differential Version: 56982494
Differential Revision: D9652088 Differential Version: 56982465
Differential Revision: D9652089 Differential Version: 56982470
Differential Revision: D9663476 Differential Version: 56982467
Differential Revision: D9623916 Differential Version: 57101548
Differential Revision: D9644700 Differential Version: 57101652
Differential Revision: D9652088 Differential Version: 57101545
Differential Revision: D9652089 Differential Version: 57101550
Differential Revision: D9663476 Differential Version: 57101556
Differential Revision: D9623916 Differential Version: 57135223
Differential Revision: D9644700 Differential Version: 57135224
Differential Revision: D9652088 Differential Version: 57135218
Differential Revision: D9652089 Differential Version: 57135219
Differential Revision: D9663476 Differential Version: 57135226
Differential Revision: D9694327 Differential Version: 57135227
Differential Revision: D9694326 Differential Version: 57135216
Differential Revision: D9694918 Differential Version: 57140103
Differential Revision: D9623916 Differential Version: 57214033
Differential Revision: D9644700 Differential Version: 57214023
Differential Revision: D9652088 Differential Version: 57214005
Differential Revision: D9652089 Differential Version: 57214030
Differential Revision: D9778043 Differential Version: 57695967
Differential Revision: D9694327 Differential Version: 57695973
Differential Revision: D9778042 Differential Version: 57695963
Differential Revision: D9694326 Differential Version: 57695965
Differential Revision: D9694918 Differential Version: 57695970
Differential Revision: D9728631 Differential Version: 57695969
Differential Revision: D9778043 Differential Version: 57757843
Differential Revision: D9694327 Differential Version: 57757844
Differential Revision: D9778042 Differential Version: 57757838
Differential Revision: D9694326 Differential Version: 57757847
Differential Revision: D9694918 Differential Version: 57757835
Differential Revision: D9728631 Differential Version: 57757841
Differential Revision: D9694327 Differential Version: 57851523
Differential Revision: D9778042 Differential Version: 57851524
Differential Revision: D9694326 Differential Version: 57851519
Differential Revision: D9694918 Differential Version: 57851521
Differential Revision: D9728631 Differential Version: 57851525
Differential Revision: D9728631 Differential Version: 58048804
smessmer
requested review from
ebetica,
goldsborough,
pietern and
teng-li
as code owners
Differential Revision: D9728631 Differential Version: 58208409
zdevito
pushed a commit
to zdevito/ATen
that referenced
this pull request
Sep 18, 2018
Summary: Pull Request resolved: pytorch/pytorch#11402 - Simplify move constructor/assignment - Make more things noexcept Reviewed By: ezyang Differential Revision: D9728631 fbshipit-source-id: 92562e30ea1e4d05ca857665a02b0ca66b0739e3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack:
:black_circle: #11402 Simplify Blob move constructor/assignment 💛
:white_circle: #11817 Move blob serialization to free functions 💛
Differential Revision: D9728631