[pt1][tensor] move context_base.h to ATen/core #11336
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Differential Revision: D9545704 Differential Version: 56924075
Differential Revision: D9545704 Differential Version: 56965830
Differential Revision: D9545704 Differential Version: 57004739
Differential Revision: D9670493 Differential Version: 57013834
jerryzh168
requested review from
apaszke,
colesbury,
ezyang,
gchanan,
soumith and
zdevito
as code owners
Differential Revision: D9670493 Differential Version: 57104519
Differential Revision: D9670493 Differential Version: 57126987
Differential Revision: D9670493 Differential Version: 57131098
ezyang
reviewed
Sep 7, 2018
| @@ -1,3 +1,4 @@ | |||
| #pragma once | |||
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
ezyang
reviewed
Sep 7, 2018
| #include <ATen/core/DeviceType.h> | ||
| #include <ATen/core/Error.h> | ||
| #include <ATen/core/UniqueVoidPtr.h> | ||
| #include <ATen/core/typeid.h> |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
jerryzh168
commented
Sep 7, 2018
caffe2/core/context_base.h
Outdated
|
|
||
| #include "caffe2/core/allocator.h" | ||
| #include <ATen/core/context_base.h> | ||
| #include "caffe2/core/event.h" |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
ezyang
reviewed
Sep 7, 2018
caffe2/core/context_base.cc
Outdated
|
|
||
| } // namespace caffe2 | ||
|
|
||
| namespace at { |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
ezyang
approved these changes
Sep 7, 2018
Contributor
ezyang
left a comment
ezyang
left a comment
There was a problem hiding this comment.
In the spirit of unblocking I will approve.
Differential Revision: D9670493 Differential Version: 57156792
Differential Revision: D9670493 Differential Version: 57158240
zdevito
pushed a commit
to zdevito/ATen
that referenced
this pull request
Sep 7, 2018
Summary: Pull Request resolved: pytorch/pytorch#11336 Move `context_base.h` header to `ATen/core` and the implementations are in `caffe2/core/context_base.cc` Reviewed By: ezyang Differential Revision: D9670493 fbshipit-source-id: ce5bf2b3b4c80e9b62819f4332ce68af82720055
PenghuiCheng
pushed a commit
to PenghuiCheng/pytorch
that referenced
this pull request
Sep 11, 2018
Summary: Pull Request resolved: pytorch#11336 Move `context_base.h` header to `ATen/core` and the implementations are in `caffe2/core/context_base.cc` Reviewed By: ezyang Differential Revision: D9670493 fbshipit-source-id: ce5bf2b3b4c80e9b62819f4332ce68af82720055
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[pt1][tensor] move context_base.h to ATen/core
Move
context_base.hheader toATen/coreand the implementations are incaffe2/core/context_base.ccDifferential Revision: D9670493