Skip to content

[jit][easy] Rename cuda tests to have 'cuda' in their names #11332

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
zou3519 wants to merge 1 commit into from
Closed

[jit][easy] Rename cuda tests to have 'cuda' in their names #11332

zou3519 wants to merge 1 commit into from

Conversation

@zou3519
Copy link
Contributor

@zou3519 zou3519 commented Sep 6, 2018

Not a lot changed

@zou3519 zou3519 added 0.3 oncall: jit Add this issue/PR to JIT oncall triage queue and removed 0.3 labels Sep 6, 2018
facebook-github-bot
facebook-github-bot reviewed Sep 6, 2018
View reviewed changes
Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

zou3519 has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

zdevito
zdevito approved these changes Sep 6, 2018
View reviewed changes
Copy link
Contributor

@zdevito zdevito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have we actually checked that the memory test is working? e.g. introduced a leak and watch a test fail?

@zou3519
Copy link
Contributor Author

zou3519 commented Sep 6, 2018 •
edited
Loading

@zdevito yes, I checked that back when I was fixing the memory leak in #10222 but I'll check again.

edit: verified by leaking a tensor in c++ and running the tests. There is also a general pytorch unit test for the cuda memory checker somewhere

@ssnl
Copy link
Collaborator

ssnl commented Sep 6, 2018

The checker test is at

pytorch/test/test_cuda.py

Lines 1930 to 1952 in 0ef2b31

def test_cuda_memory_leak_detection(self):
l = []
@self.wrap_with_cuda_memory_check
def no_leak():
pass
@self.wrap_with_cuda_memory_check
def leak_gpu0():
l.append(torch.tensor(10, device=torch.device("cuda:0")))
no_leak()
with self.assertRaisesRegex(AssertionError, r"leaked \d+ bytes CUDA memory on device 0"):
leak_gpu0()
if TEST_MULTIGPU:
@self.wrap_with_cuda_memory_check
def leak_gpu1():
l.append(torch.tensor(10, device=torch.device("cuda:1")))
with self.assertRaisesRegex(AssertionError, r"leaked \d+ bytes CUDA memory on device 1"):
leak_gpu1()

@zou3519 zou3519 deleted the jit-cuda-tests branch September 6, 2018 23:08
@zou3519 zou3519 restored the jit-cuda-tests branch September 6, 2018 23:08
PenghuiCheng pushed a commit to PenghuiCheng/pytorch that referenced this pull request Sep 11, 2018
@zou3519 @PenghuiCheng
Rename cuda tests to have 'cuda' in their names (pytorch#11332)
ecc5a0a 
Summary:
Not a lot changed
Pull Request resolved: pytorch#11332

Differential Revision: D9683680

Pulled By: zou3519

fbshipit-source-id: 95f444e54049dd268fc10effe425ef2df79c6467
@zou3519 zou3519 deleted the jit-cuda-tests branch September 13, 2018 15:35
@ezyang ezyang added the merged label Jun 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@facebook-github-bot facebook-github-bot facebook-github-bot left review comments

@ezyang ezyang ezyang approved these changes

@zdevito zdevito zdevito approved these changes

@apaszke apaszke Awaiting requested review from apaszke

@colesbury colesbury Awaiting requested review from colesbury

@gchanan gchanan Awaiting requested review from gchanan

@soumith soumith Awaiting requested review from soumith

Assignees

No one assigned

Labels

oncall: jit Add this issue/PR to JIT oncall triage queue

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@zou3519 @ssnl @ezyang @zdevito @facebook-github-bot