Do not generate zero-numel NT by default in helper and improve to_padded_tensor msg #113162
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ded_tensor msg [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/113162
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit cdbb34c with merge base 1855153 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
…rove to_padded_tensor msg" [ghstack-poisoned]
jbschlosser
approved these changes
Nov 7, 2023
Contributor
jbschlosser
left a comment
jbschlosser
left a comment
There was a problem hiding this comment.
Thanks for the fix!
I think we should avoid a non-deterministic length loop if possible, but it's probably not that big of a deal
…rove to_padded_tensor msg" [ghstack-poisoned]
soulitzer
added
topic: not user facing
Contributor
Author
|
@pytorchbot merge |
Collaborator
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Skylion007
pushed a commit
to Skylion007/pytorch
that referenced
this pull request
Nov 14, 2023
…ded_tensor msg (pytorch#113162) Improvements: improves to_padded_tensor error message when passed a NT with zero numel Pull Request resolved: pytorch#113162 Approved by: https://github.com/jbschlosser ghstack dependencies: pytorch#113031, pytorch#112519, pytorch#113091
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Improvements: improves to_padded_tensor error message when passed a NT with zero numel