Skip to content

Conversation

@nhynes
Copy link
Contributor

@nhynes nhynes commented Mar 28, 2017

This is useful when creating a generic loader+model in which variables are passed around as [optional] kwargs.

This comment was marked as off-topic.

This comment was marked as off-topic.

@apaszke
Copy link
Contributor

apaszke commented Mar 30, 2017

@pytorchbot test this please

Copy link
Contributor

@apaszke apaszke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please also add a test for that in test_utils.py?

@soumith
Copy link
Contributor

soumith commented Mar 31, 2017

@pytorchbot add to whitelist

This comment was marked as off-topic.

@nhynes nhynes closed this May 15, 2017
jjsjann123 pushed a commit to jjsjann123/pytorch that referenced this pull request Nov 5, 2021
…ions (pytorch#1131)

Fixes pytorch#1102 

This PR implements the second approach mentioned in pytorch#1102 For example, indexing and predicates are changed from:

```
      = T0[(((((nvfuser_index_t)blockIdx.x) * ((nvfuser_index_t)blockDim.y)) + ((nvfuser_index_t)threadIdx.y)) * T0.stride[0])]
```

to:

```
 = T0[(((((nvfuser_index_t)blockIdx.x) * 4) + ((nvfuser_index_t)threadIdx.y)) * T0.stride[0])]
```

The use of `blockDim.y` is replaced by the extent of the second axis of `T0`, which is `4` in this case. This change only matters when a parallel type is not exact (in this case `TIDy`). 

The indexing change only needed to change `getExtent` in index_compute.cpp. However, we also need to predicate `threadIdx` and `blockIdx` to be smaller than IterDomain extents. That's implemented as `ParallelizedDomainPredicate` in predicate_compute.h.
syed-ahmed pushed a commit to syed-ahmed/pytorch that referenced this pull request Sep 22, 2022
dllehr-amd pushed a commit to dllehr-amd/pytorch that referenced this pull request Apr 5, 2023
…h#1131)

Support for MIOpen immediate mode is not enabled in release/1.11 release/1.12 branches which is required
for the test_Conv2d_naive_groups test to pass - https://ontrack-internal.amd.com/browse/SWDEV-355273
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants