-
Notifications
You must be signed in to change notification settings - Fork 26.3k
[ci][ez] Add job_id to emit_metrics #113099
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/113099
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 89e2bc4 with merge base 77d5f03 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
As in title. Also print the job id in the step since I'm struggling to find it Pull Request resolved: pytorch#113099 Approved by: https://github.com/seemethere
Copy-n-paste code from `_mac-test.yml` added in #113099
Move `get-job-id` steps before running the tests and copy-n-paste environment variables from `_mac-test.yml` added in #113099 Should fix the following warning during MPS test run: ``` /Users/ec2-user/runner/_work/pytorch/pytorch/tools/stats/upload_metrics.py:147: UserWarning: Not emitting metrics for td_test_failure_stats_v2. Missing job_id. Please set the JOB_ID environment variable to pass in this value. warn(f"Not emitting metrics for {metric_name}. {e}") ``` Pull Request resolved: #136791 Approved by: https://github.com/albanD, https://github.com/izaitsevfb
As in title.
Also print the job id in the step since I'm struggling to find it