Skip to content

Conversation

@clee2000
Copy link
Contributor

@clee2000 clee2000 commented Nov 6, 2023

As in title.

Also print the job id in the step since I'm struggling to find it

@pytorch-bot
Copy link

pytorch-bot bot commented Nov 6, 2023

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/113099

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 89e2bc4 with merge base 77d5f03 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added the topic: not user facing topic category label Nov 6, 2023
@clee2000 clee2000 marked this pull request as ready for review November 7, 2023 16:59
@clee2000 clee2000 requested a review from a team as a code owner November 7, 2023 16:59
@clee2000 clee2000 changed the title [ci] Add job_id to emit_metrics [ci][ez] Add job_id to emit_metrics Nov 7, 2023
@clee2000
Copy link
Contributor Author

clee2000 commented Nov 8, 2023

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Nov 8, 2023
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

Skylion007 pushed a commit to Skylion007/pytorch that referenced this pull request Nov 14, 2023
As in title.

Also print the job id in the step since I'm struggling to find it
Pull Request resolved: pytorch#113099
Approved by: https://github.com/seemethere
@github-actions github-actions bot deleted the csl/job_id_emit_metric branch January 17, 2024 19:42
malfet added a commit that referenced this pull request Sep 26, 2024
Copy-n-paste code from `_mac-test.yml` added in #113099
pytorchmergebot pushed a commit that referenced this pull request Sep 26, 2024
Move `get-job-id` steps before running the tests and copy-n-paste environment variables from `_mac-test.yml` added in #113099

Should fix the following warning during MPS test run:
```
/Users/ec2-user/runner/_work/pytorch/pytorch/tools/stats/upload_metrics.py:147: UserWarning: Not emitting metrics for td_test_failure_stats_v2. Missing job_id. Please set the JOB_ID environment variable to pass in this value.
  warn(f"Not emitting metrics for {metric_name}. {e}")
```
Pull Request resolved: #136791
Approved by: https://github.com/albanD, https://github.com/izaitsevfb
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/trunk Trigger trunk jobs on your pull request Merged topic: not user facing topic category

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants