fix empty net type #11286
Closed
fix empty net type #11286
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
facebook-github-bot
left a comment
facebook-github-bot
left a comment
There was a problem hiding this comment.
harouwu is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Contributor
facebook-github-bot
left a comment
facebook-github-bot
left a comment
There was a problem hiding this comment.
harouwu is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Summary: Turns out that '' net.type is not acceptable to CreateNet. But empty net.type is acceptable. Fix that in this diff. Also this is related to T33613083 Pull Request resolved: #11286 Reviewed By: wat3rBro Differential Revision: D9659920 Pulled By: wat3rBro fbshipit-source-id: 1ef4c6f31b4bb52b7ff2bcdf36c92ca0693d5590
Maratyszcza
approved these changes
Sep 6, 2018
Contributor
Maratyszcza
left a comment
Maratyszcza
left a comment
There was a problem hiding this comment.
dogscience, but lgtm
PenghuiCheng
pushed a commit
to PenghuiCheng/pytorch
that referenced
this pull request
Sep 11, 2018
Summary: Turns out that '' net.type is not acceptable to CreateNet. But empty net.type is acceptable. Fix that in this diff. Also this is related to T33613083 Pull Request resolved: pytorch#11286 Reviewed By: Maratyszcza, wat3rBro Differential Revision: D9659920 Pulled By: harouwu fbshipit-source-id: d68f24b754e18e1121f029656d885c48ab101946
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Turns out that '' net.type is not acceptable to CreateNet.
But empty net.type is acceptable.
Fix that in this diff. Also this is related to T33613083
Differential Revision: D9659920