[DCP] Add fsspec.transaction context when writing checkpoint to storage #112191
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wz337
requested review from
H-Huang,
awgu,
d4l3k,
fduwjj,
fegin,
kiukchung,
kwen2501,
mrshenli,
rohan-varma,
wanchaol and
zhaojuanmao
as code owners
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/112191
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New Failure, 1 Unrelated FailureAs of commit 167491b with merge base 5b71834 ( NEW FAILURE - The following job has failed:
BROKEN TRUNK - The following job failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
|
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D50701929 |
wz337
force-pushed
the
export-D50701929
branch
from
497be62 to
00ded68
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D50701929 |
1 similar comment
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D50701929 |
wz337
added a commit
to wz337/pytorch
that referenced
this pull request
Oct 26, 2023
…ge (pytorch#112191) Summary: Adding fsspec.transaction to safeguard checkpointing writing. With the context, it should only commit if there was no exception and discard otherwise. Test Plan: ``` command: buck test @//mode/dev-nosan //caffe2/test/distributed/checkpoint/fb:test_fsspec_filesystem -- --print-passing-details Buck UI: https://www.internalfb.com/buck2/7eff3718-9c08-4397-86ae-31ba0bdee65c Test UI: https://www.internalfb.com/intern/testinfra/testrun/4785074810069469 Network: Up: 0B Down: 0B Jobs completed: 10. Time elapsed: 1:25.0s. Tests finished: Pass 3. Fail 0. Fatal 0. Skip 0. Build failure 0 ``` Reviewed By: rohan-varma Differential Revision: D50701929
wz337
force-pushed
the
export-D50701929
branch
from
00ded68 to
89c17a1
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D50701929 |
rohan-varma
approved these changes
Oct 26, 2023
…ge (pytorch#112191) Summary: Adding fsspec.transaction to safeguard checkpointing writing. With the context, it should only commit if there was no exception and discard otherwise. Test Plan: ``` command: buck test @//mode/dev-nosan //caffe2/test/distributed/checkpoint/fb:test_fsspec_filesystem -- --print-passing-details Buck UI: https://www.internalfb.com/buck2/7eff3718-9c08-4397-86ae-31ba0bdee65c Test UI: https://www.internalfb.com/intern/testinfra/testrun/4785074810069469 Network: Up: 0B Down: 0B Jobs completed: 10. Time elapsed: 1:25.0s. Tests finished: Pass 3. Fail 0. Fatal 0. Skip 0. Build failure 0 ``` Reviewed By: rohan-varma Differential Revision: D50701929
wz337
force-pushed
the
export-D50701929
branch
from
89c17a1 to
167491b
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D50701929 |
Contributor
|
@pytorchbot merge (Initiating merge automatically since Phabricator Diff has merged) |
Collaborator
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
xuhancn
pushed a commit
to xuhancn/pytorch
that referenced
this pull request
Nov 7, 2023
…ge (pytorch#112191) Summary: Adding fsspec.transaction to safeguard checkpointing writing. With the context, it should only commit if there was no exception and discard otherwise. Test Plan: ``` command: buck test @//mode/dev-nosan //caffe2/test/distributed/checkpoint/fb:test_fsspec_filesystem -- --print-passing-details ``` Reviewed By: rohan-varma Differential Revision: D50701929 Pull Request resolved: pytorch#112191 Approved by: https://github.com/rohan-varma
Skylion007
pushed a commit
to Skylion007/pytorch
that referenced
this pull request
Nov 14, 2023
…ge (pytorch#112191) Summary: Adding fsspec.transaction to safeguard checkpointing writing. With the context, it should only commit if there was no exception and discard otherwise. Test Plan: ``` command: buck test @//mode/dev-nosan //caffe2/test/distributed/checkpoint/fb:test_fsspec_filesystem -- --print-passing-details ``` Reviewed By: rohan-varma Differential Revision: D50701929 Pull Request resolved: pytorch#112191 Approved by: https://github.com/rohan-varma
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Adding fsspec.transaction to safeguard checkpointing writing. With the context, it should only commit if there was no exception and discard otherwise.
Test Plan:
Reviewed By: rohan-varma
Differential Revision: D50701929