[release only] Pin Docker images for release. #111971
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/111971
Note: Links to docs will display an error until the docs builds have been completed. ❌ 4 New Failures, 3 Unrelated FailuresAs of commit 7c0c64c with merge base 138e289 ( NEW FAILURES - The following jobs have failed:
FLAKY - The following jobs failed but were likely due to flakiness present on trunk:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
atalman
changed the title
atalman
added
ciflow/binaries_conda
ciflow/binaries_wheel
malfet
reviewed
Oct 25, 2023
atalman
changed the title
atalman
force-pushed
the
fix_release_docker_build
branch
from
286bfcf to
da8f317
Compare
atalman
force-pushed
the
fix_release_docker_build
branch
from
da8f317 to
3f9118e
Compare
atalman
changed the title
huydhn
approved these changes
Oct 25, 2023
malfet
approved these changes
Oct 25, 2023
Contributor
|
IMO we should tag those, otherwise they might be recycled after some period of time |
This was referenced Nov 1, 2023
pytorchmergebot
pushed a commit
that referenced
this pull request
Nov 2, 2023
This will help prevent a commit like pytorch/builder@7790132 pushing to release branch from overwrite the Docker images used in main. In addition, the `DEFAULT_TAG` can be easily updated to `2.1` for example when doing branch cut release. This basically pins the Docker images like #111971 Pull Request resolved: #112692 Approved by: https://github.com/malfet
xuhancn
pushed a commit
to xuhancn/pytorch
that referenced
this pull request
Nov 7, 2023
This will help prevent a commit like pytorch/builder@7790132 pushing to release branch from overwrite the Docker images used in main. In addition, the `DEFAULT_TAG` can be easily updated to `2.1` for example when doing branch cut release. This basically pins the Docker images like pytorch#111971 Pull Request resolved: pytorch#112692 Approved by: https://github.com/malfet
Skylion007
pushed a commit
to Skylion007/pytorch
that referenced
this pull request
Nov 14, 2023
This will help prevent a commit like pytorch/builder@7790132 pushing to release branch from overwrite the Docker images used in main. In addition, the `DEFAULT_TAG` can be easily updated to `2.1` for example when doing branch cut release. This basically pins the Docker images like pytorch#111971 Pull Request resolved: pytorch#112692 Approved by: https://github.com/malfet
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pins all Docker images used for building to Sept 19 timeframe (time of final RC build for release 2.1.0)