Add complex64 and complex128 dtypes #11173
Conversation
ezyang
requested review from
apaszke,
colesbury,
gchanan,
soumith and
zdevito
as code owners
ezyang
force-pushed
the
pr/complex-dtype
branch
from
698fc4b to
1655086
Compare
aten/src/ATen/core/ScalarType.h
Outdated
| _(float,Float,d) /* 6 */ \ | ||
| _(double,Double,d) /* 7 */ | ||
| _(double,Double,d) /* 7 */ \ | ||
| _(std::complex<float>,ComplexFloat,z) /* 8 */ \ |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
|
Why is there a revert commit? edit: Is it to fix build? |
|
Yeah, this can't merge as is, there's a temporary revert so that I can actually do local dev. ComplexHalf seems like a reasonable thing to add for future compatibility. |
|
Hmm, ComplexHalf is a bit troublesome to use with |
ezyang
force-pushed
the
pr/complex-dtype
branch
2 times, most recently
from
0065ff5 to
4fc9827
Compare
facebook-github-bot
left a comment
facebook-github-bot
left a comment
There was a problem hiding this comment.
ezyang has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
facebook-github-bot
left a comment
facebook-github-bot
left a comment
There was a problem hiding this comment.
ezyang has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
|
One way would be to do the same thing we did for |
|
Yeah, that's what I ended up doing in this patch. |
We don't generate a corresponding Type implementations for them, so this doesn't do anything at the moment. We don't plan on supporting complex32 in the near future, but it is added to reserve the name and number in case we do at some point in the future. Signed-off-by: Edward Z. Yang <[email protected]>
ezyang
force-pushed
the
pr/complex-dtype
branch
from
3e8c591 to
fe475cf
Compare
facebook-github-bot
left a comment
facebook-github-bot
left a comment
There was a problem hiding this comment.
ezyang has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Summary: We don't generate a corresponding Type implementations for them, so this doesn't do anything at the moment. We don't plan on supporting complex32 in the near future, but it is added to reserve the name and number in case we do at some point in the future. Pull Request resolved: pytorch/pytorch#11173 Reviewed By: SsnL Differential Revision: D9627477 Pulled By: ezyang fbshipit-source-id: f49a44ab1c92d8a33130c249ac7b234f210a65e6
Summary: We don't generate a corresponding Type implementations for them, so this doesn't do anything at the moment. We don't plan on supporting complex32 in the near future, but it is added to reserve the name and number in case we do at some point in the future. Pull Request resolved: pytorch#11173 Reviewed By: SsnL Differential Revision: D9627477 Pulled By: ezyang fbshipit-source-id: f49a44ab1c92d8a33130c249ac7b234f210a65e6
3 participants
No description provided.