Skip to content

feat(optim): use has_complex shortcut flag for all applicable optimizers, use _view_as_real auxiliary function #110706

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
jon-chuang wants to merge 5 commits into from
Closed

feat(optim): use has_complex shortcut flag for all applicable optimizers, use _view_as_real auxiliary function #110706

jon-chuang wants to merge 5 commits into from

Conversation

@jon-chuang
Copy link
Collaborator

@jon-chuang jon-chuang commented Oct 6, 2023

Follow up to: #110607

CC: @lezcano @janeyx99

@pytorch-bot
Copy link

pytorch-bot bot commented Oct 6, 2023 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/110706

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 3733443 with merge base 3db0095 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

jon-chuang
jon-chuang commented Oct 6, 2023
View reviewed changes
lezcano
lezcano approved these changes Oct 6, 2023
View reviewed changes
Copy link
Collaborator

@lezcano lezcano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! This looks much cleaner, thank you.

In the future, you may want to consider using https://github.com/ezyang/ghstack to stack related PRs

@jon-chuang
Copy link
Collaborator Author

jon-chuang commented Oct 6, 2023

In the future, you may want to consider using https://github.com/ezyang/ghstack to stack related PRs

yep just gotta get used to it 😛

@lezcano
Copy link
Collaborator

lezcano commented Oct 6, 2023

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Oct 6, 2023
@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Oct 6, 2023

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@jon-chuang jon-chuang changed the title feat(optim): use has_complex shortcut flag, use _view_as_real auxiliary function feat(optim): use has_complex shortcut flag for all applicable optimizers, use _view_as_real auxiliary function Oct 6, 2023
@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Oct 6, 2023

Merge failed

Reason: 1 jobs have failed, first few of them are: trunk / macos-12-py3-arm64 / test (default, 1, 3, macos-m1-12)

Details for Dev Infra team Raised by workflow job

@albanD albanD removed their request for review October 6, 2023 14:40
@lezcano
Copy link
Collaborator

lezcano commented Oct 6, 2023

the failures are real

@jon-chuang
Copy link
Collaborator Author

jon-chuang commented Oct 6, 2023 •
edited
Loading

Yes, I'm diagnosing them now (they are a dynamo bug for unpacking const tuple from _init_group return)

@jon-chuang jon-chuang mentioned this pull request Oct 6, 2023
Closed
@jon-chuang
Copy link
Collaborator Author

jon-chuang commented Oct 31, 2023

I'm going to revive this and merge, except for adagrad, which depends on #110709

Will ship an adagrad one after we merge that.

@jon-chuang
Copy link
Collaborator Author

jon-chuang commented Oct 31, 2023

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Oct 31, 2023

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

pytorchmergebot pushed a commit that referenced this pull request Nov 1, 2023
@jon-chuang @pytorchmergebot
fix(dynamo): Optimizer._init_group did not handle return value (#11…
7691836 
…0709)

blocks: #110706

Causes a bug for all optimizers that use _init_group return value.

`compile` + _init_group ret value is not on testing path. So we also add test.

Pull Request resolved: #110709
Approved by: https://github.com/ezyang
@jon-chuang jon-chuang mentioned this pull request Nov 2, 2023
Closed
pytorchmergebot pushed a commit that referenced this pull request Nov 2, 2023
@jon-chuang @pytorchmergebot
[optim/dynamo] shortcut adagrad with has_complex (#112722)
954cba2 
Follow up to #110706, it was missed as depended on another fix

Pull Request resolved: #112722
Approved by: https://github.com/albanD
xuhancn pushed a commit to xuhancn/pytorch that referenced this pull request Nov 7, 2023
@jon-chuang @xuhancn
feat(optim): use has_complex shortcut flag for all applicable optim…
e53b14a 
…izers, use `_view_as_real` auxiliary function (pytorch#110706)

Follow up to: pytorch#110607

CC: @lezcano @janeyx99
Pull Request resolved: pytorch#110706
Approved by: https://github.com/lezcano
xuhancn pushed a commit to xuhancn/pytorch that referenced this pull request Nov 7, 2023
@jon-chuang @xuhancn
fix(dynamo): Optimizer._init_group did not handle return value (pyt…
bca7343 
…orch#110709)

blocks: pytorch#110706

Causes a bug for all optimizers that use _init_group return value.

`compile` + _init_group ret value is not on testing path. So we also add test.

Pull Request resolved: pytorch#110709
Approved by: https://github.com/ezyang
xuhancn pushed a commit to xuhancn/pytorch that referenced this pull request Nov 7, 2023
@jon-chuang @xuhancn
[optim/dynamo] shortcut adagrad with has_complex (pytorch#112722)
07b5cfe 
Follow up to pytorch#110706, it was missed as depended on another fix

Pull Request resolved: pytorch#112722
Approved by: https://github.com/albanD
Skylion007 pushed a commit to Skylion007/pytorch that referenced this pull request Nov 14, 2023
@jon-chuang @Skylion007
feat(optim): use has_complex shortcut flag for all applicable optim…
1f43357 
…izers, use `_view_as_real` auxiliary function (pytorch#110706)

Follow up to: pytorch#110607

CC: @lezcano @janeyx99
Pull Request resolved: pytorch#110706
Approved by: https://github.com/lezcano
Skylion007 pushed a commit to Skylion007/pytorch that referenced this pull request Nov 14, 2023
@jon-chuang @Skylion007
fix(dynamo): Optimizer._init_group did not handle return value (pyt…
9222362 
…orch#110709)

blocks: pytorch#110706

Causes a bug for all optimizers that use _init_group return value.

`compile` + _init_group ret value is not on testing path. So we also add test.

Pull Request resolved: pytorch#110709
Approved by: https://github.com/ezyang
Skylion007 pushed a commit to Skylion007/pytorch that referenced this pull request Nov 14, 2023
@jon-chuang @Skylion007
[optim/dynamo] shortcut adagrad with has_complex (pytorch#112722)
f868397 
Follow up to pytorch#110706, it was missed as depended on another fix

Pull Request resolved: pytorch#112722
Approved by: https://github.com/albanD
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lezcano lezcano lezcano approved these changes

@janeyx99 janeyx99 Awaiting requested review from janeyx99 janeyx99 is a code owner

Assignees

No one assigned

Labels

ciflow/trunk Trigger trunk jobs on your pull request Merged open source release notes: optim

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@jon-chuang @lezcano @pytorchmergebot @pytorchbot