Skip to content

Conversation

@jon-chuang
Copy link
Collaborator

@jon-chuang jon-chuang commented Oct 4, 2023

Follow up to: #110454, which defines the infra for sparse multi tensor optimizer testing

@pytorch-bot
Copy link

pytorch-bot bot commented Oct 4, 2023

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/110562

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (3 Unrelated Failures)

As of commit bd8f77b with merge base 9e72c9c (image):

FLAKY - The following job failed but was likely due to flakiness present on trunk:

UNSTABLE - The following jobs failed but were likely due to flakiness present on trunk and has been marked as unstable:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@jon-chuang jon-chuang changed the title feat(optim): add sgd sparse multitensor to testing path feat(optim): add SGD sparse multitensor to testing path Oct 4, 2023
@janeyx99
Copy link
Contributor

janeyx99 commented Oct 5, 2023

Happy to approve this once it's been rebased properly--let me know

@jon-chuang jon-chuang marked this pull request as ready for review October 5, 2023 20:57
@jon-chuang
Copy link
Collaborator Author

@janeyx99 ready now

@janeyx99
Copy link
Contributor

janeyx99 commented Oct 6, 2023

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Oct 6, 2023
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants