Skip to content

Change flash attention outputs to be SymInt instead of int #110533

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
ezyang wants to merge 3 commits into from
Closed

Change flash attention outputs to be SymInt instead of int #110533

ezyang wants to merge 3 commits into from

Conversation

@ezyang
Copy link
Contributor

@ezyang ezyang commented Oct 4, 2023 •
edited
Loading

@ezyang
Change flash attention outputs to be SymInt instead of int
eec2383 
Signed-off-by: Edward Z. Yang <[email protected]>

[ghstack-poisoned]
@pytorch-bot
Copy link

pytorch-bot bot commented Oct 4, 2023 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/110533

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (2 Unrelated Failures)

As of commit 02e5f2e with merge base 5220d0d (image):

UNSTABLE - The following jobs failed but were likely due to flakiness present on trunk and has been marked as unstable:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

albanD
albanD approved these changes Oct 4, 2023
View reviewed changes
Copy link
Collaborator

@albanD albanD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SGTM

@ezyang
Update on "Change flash attention outputs to be SymInt instead of int"
21d32be 
Signed-off-by: Edward Z. Yang <ezyangmeta.com>

[ghstack-poisoned]
ezyang added a commit that referenced this pull request Oct 4, 2023
@ezyang
Change flash attention outputs to be SymInt instead of int
2499a6f 
Signed-off-by: Edward Z. Yang <ezyangmeta.com>

ghstack-source-id: 08b2eaf
Pull Request resolved: #110533
@drisspg drisspg mentioned this pull request Oct 4, 2023
Closed
@ezyang
Update on "Change flash attention outputs to be SymInt instead of int"
02e5f2e 
Fixes #110322

Signed-off-by: Edward Z. Yang <ezyangmeta.com>

cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng Xia-Weiwen wenzhe-nrv jiayisunx peterbell10 ipiszy yf225 chenyang78 kadeng muchulee8 aakhundov ColinPeppler

[ghstack-poisoned]
@ezyang
Copy link
Contributor Author

ezyang commented Oct 4, 2023

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Oct 4, 2023
ezyang added a commit that referenced this pull request Oct 4, 2023
@ezyang
Change flash attention outputs to be SymInt instead of int
e2c026e 
Signed-off-by: Edward Z. Yang <ezyangmeta.com>

ghstack-source-id: 5e42d9c
Pull Request resolved: #110533
@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Oct 4, 2023

Merge failed

Reason: This PR needs a release notes: label
If your changes are user facing and intended to be a part of release notes, please use a label starting with release notes:.

If not, please add the topic: not user facing label.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "topic: not user facing"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

Details for Dev Infra team Raised by workflow job

@ezyang ezyang added release notes: composability release notes category topic: bug fixes topic category labels Oct 5, 2023
@ezyang
Copy link
Contributor Author

ezyang commented Oct 5, 2023

@pytorchbot merge -f "straggler jobs only"

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Oct 5, 2023

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@facebook-github-bot facebook-github-bot deleted the gh/ezyang/2377/head branch October 8, 2023 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@albanD albanD albanD approved these changes

@soulitzer soulitzer Awaiting requested review from soulitzer

@antoniojkim antoniojkim Awaiting requested review from antoniojkim

@bdhirsh bdhirsh Awaiting requested review from bdhirsh

@miladm miladm Awaiting requested review from miladm

@SherlockNoMad SherlockNoMad Awaiting requested review from SherlockNoMad

@voznesenskym voznesenskym Awaiting requested review from voznesenskym

@wconstab wconstab Awaiting requested review from wconstab

@cpuhrsch cpuhrsch Awaiting requested review from cpuhrsch

@drisspg drisspg Awaiting requested review from drisspg

@jbschlosser jbschlosser Awaiting requested review from jbschlosser

Assignees

No one assigned

Labels

ciflow/inductor ciflow/trunk Trigger trunk jobs on your pull request Merged module: inductor release notes: composability release notes category topic: bug fixes topic category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ezyang @pytorchmergebot @albanD