Devirtualize StorageImpl deconstructor #11018
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cpuhrsch
requested review from
apaszke,
colesbury,
ezyang,
gchanan,
soumith and
zdevito
as code owners
Further align at::StorageImpl with caffe2::StorageImpl
Contributor
facebook-github-bot
left a comment
facebook-github-bot
left a comment
There was a problem hiding this comment.
cpuhrsch has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
ezyang
approved these changes
Aug 29, 2018
zdevito
pushed a commit
to zdevito/ATen
that referenced
this pull request
Aug 30, 2018
Summary: Further align at::StorageImpl with caffe2::StorageImpl Pull Request resolved: pytorch/pytorch#11018 Reviewed By: ezyang Differential Revision: D9562256 Pulled By: cpuhrsch fbshipit-source-id: d929317f6226a1e2550b78034b723afbae343aaa
PenghuiCheng
pushed a commit
to PenghuiCheng/pytorch
that referenced
this pull request
Sep 11, 2018
Summary: Further align at::StorageImpl with caffe2::StorageImpl Pull Request resolved: pytorch#11018 Reviewed By: ezyang Differential Revision: D9562256 Pulled By: cpuhrsch fbshipit-source-id: d929317f6226a1e2550b78034b723afbae343aaa
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Further align at::StorageImpl with caffe2::StorageImpl