[pytorch][PR] Make Type a (mostly) pure virtual class; TypeDefault for impls (#11013) #11013
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Differential Revision: D9557315 Differential Version: 56407314
Differential Revision: D9557315 Differential Version: 56413294
Differential Revision: D9557315 Differential Version: 56415719
Differential Revision: D9557315 Differential Version: 56424143
Differential Revision: D9557315 Differential Version: 56437859
Differential Revision: D9561478 Differential Version: 56437861
ezyang
requested review from
apaszke,
colesbury,
gchanan,
soumith and
zdevito
as code owners
Differential Revision: D9561478 Differential Version: 56440382
Differential Revision: D9561478 Differential Version: 56440854
Differential Revision: D9557315 Differential Version: 56444203
Differential Revision: D9561478 Differential Version: 56446440
Differential Revision: D9561478 Differential Version: 56449391
Contributor
Author
|
@pytorchbot retest this please |
1 similar comment
Contributor
Author
|
@pytorchbot retest this please |
cpuhrsch
approved these changes
Aug 30, 2018
Differential Revision: D9561478 Differential Version: 56541404
ezyang
requested review from
Yangqing,
anderspapitto,
bddppq,
dzhulgakov,
houseroad,
jamesr66a,
pietern,
smessmer and
teng-li
as code owners
Differential Revision: D9561478 Differential Version: 56541860
Differential Revision: D9561478 Differential Version: 56652964
ezyang
changed the title
…11181) Differential Revision: D9561478 Differential Version: 56766544
ezyang
changed the title
ezyang
added a commit
to ezyang/pytorch
that referenced
this pull request
Sep 2, 2018
…ch#11013) (pytorch#11013) Summary: Pull Request resolved: pytorch#11013 Previously, the parent class Type also contained a large number of implementations, for things like broadcasting and native functions that didn't need dispatch. We'd like to be able to reference this interface from Tensor even when we don't have any of these implementations are available. To do this, we convert Type into a truly pure virtual interface, and move all of the implementations to TypeDefault. Pull Request resolved: pytorch#11181 Differential Revision: D9561478 fbshipit-source-id: e0fb7c19aa088e8325d2c1bc4522234d5ecd5baf
Differential Revision: D9561478 Differential Version: 56766790
Differential Revision: D9561478 Differential Version: 56768709
zdevito
pushed a commit
to zdevito/ATen
that referenced
this pull request
Sep 2, 2018
…3) (#11013) Summary: Pull Request resolved: pytorch/pytorch#11013 Previously, the parent class Type also contained a large number of implementations, for things like broadcasting and native functions that didn't need dispatch. We'd like to be able to reference this interface from Tensor even when we don't have any of these implementations are available. To do this, we convert Type into a truly pure virtual interface, and move all of the implementations to TypeDefault. Pull Request resolved: pytorch/pytorch#11181 Differential Revision: D9561478 Pulled By: ezyang fbshipit-source-id: 13c49d80bc547551adf524b1cf1d691bfe311133
PenghuiCheng
pushed a commit
to PenghuiCheng/pytorch
that referenced
this pull request
Sep 11, 2018
…ch#11013) (pytorch#11013) Summary: Pull Request resolved: pytorch#11013 Previously, the parent class Type also contained a large number of implementations, for things like broadcasting and native functions that didn't need dispatch. We'd like to be able to reference this interface from Tensor even when we don't have any of these implementations are available. To do this, we convert Type into a truly pure virtual interface, and move all of the implementations to TypeDefault. Pull Request resolved: pytorch#11181 Differential Revision: D9561478 Pulled By: ezyang fbshipit-source-id: 13c49d80bc547551adf524b1cf1d691bfe311133
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[pytorch][PR] Make Type a (mostly) pure virtual class; TypeDefault for impls (#11013)
Previously, the parent class Type also contained a large number
of implementations, for things like broadcasting and native
functions that didn't need dispatch. We'd like to be able
to reference this interface from Tensor even when we don't
have any of these implementations are available.
To do this, we convert Type into a truly pure virtual interface,
and move all of the implementations to TypeDefault.
GitHub Author: Edward Yang [email protected]
Differential Revision: D9561478