Add flush to logging messages higher than INFO. #10983
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Tested locally by running bin/smart_tensor_printer_test and see results passing. |
Contributor
facebook-github-bot
left a comment
facebook-github-bot
left a comment
There was a problem hiding this comment.
Yangqing has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Contributor
Author
|
@pytorchbot retest this please - seems to be transient test error in pr/caffe2-py2-cuda9.1-cudnn7-ubuntu16.04-test |
PenghuiCheng
pushed a commit
to PenghuiCheng/pytorch
that referenced
this pull request
Sep 11, 2018
Summary: This probably fixes the logging test error that orionr is encountering - haven't tested locally but wanted to send out a PR to kick off CI. Pull Request resolved: pytorch#10983 Reviewed By: ezyang Differential Revision: D9552607 Pulled By: Yangqing fbshipit-source-id: 9ac019031ffd9c03972144df04a836e5dcdafe02
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This probably fixes the logging test error that @orionr is encountering - haven't tested locally but wanted to send out a PR to kick off CI.