Skip to content

Revert "[AOTInductor] Include constants in AOTInductor .so file. (#10… #108349

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
desertfire wants to merge 1 commit into from
Closed

Revert "[AOTInductor] Include constants in AOTInductor .so file. (#10… #108349

desertfire wants to merge 1 commit into from

Conversation

@desertfire
Copy link
Contributor

@desertfire desertfire commented Aug 31, 2023 •
edited by pytorch-bot bot
Loading

@pytorch-bot
Copy link

pytorch-bot bot commented Aug 31, 2023 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/108349

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (4 Unrelated Failures)

As of commit 193aed5 with merge base 150088a (image):

FLAKY - The following jobs failed but were likely due to flakiness present on trunk:

BROKEN TRUNK - The following jobs failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@desertfire desertfire requested a review from malfet August 31, 2023 14:51
@desertfire desertfire added the topic: not user facing topic category label Aug 31, 2023
@desertfire
Copy link
Contributor Author

desertfire commented Aug 31, 2023

@pytorchbot merge -f "sync with fbcode revert"

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Aug 31, 2023

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Aug 31, 2023

Merge failed

Reason: Approval needed from one of the following:
YazhiGao, jisaacso, jiayisuse, zhangxy988, aaronenyeshi, ...

Details for Dev Infra team Raised by workflow job

Failing merge rule: Core Maintainers

@desertfire
Copy link
Contributor Author

desertfire commented Aug 31, 2023

@pytorchbot merge -f "sync with fbcode revert"

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Aug 31, 2023

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@desertfire desertfire deleted the revert_107718 branch September 24, 2024 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zhxchen17 zhxchen17 zhxchen17 approved these changes

@malfet malfet Awaiting requested review from malfet

+1 more reviewer

@aakhundov aakhundov aakhundov approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

ciflow/inductor Merged module: dynamo module: inductor topic: not user facing topic category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@desertfire @pytorchmergebot @zhxchen17 @aakhundov