Skip to content

torch._numpy: remove noops and half-implemented nan-functions #107596

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
ev-br wants to merge 3 commits into from
Closed

torch._numpy: remove noops and half-implemented nan-functions #107596

ev-br wants to merge 3 commits into from

Conversation

@ev-br
Copy link
Collaborator

@ev-br ev-br commented Aug 21, 2023 •
edited by pytorch-bot bot
Loading

@ev-br ev-br requested review from mruberry and ngimel as code owners August 21, 2023 14:56
@pytorch-bot
Copy link

pytorch-bot bot commented Aug 21, 2023 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/107596

Note: Links to docs will display an error until the docs builds have been completed.

✅ 1 Unrelated Failure

As of commit 67cb5cc with merge base 796ce67 (image):

BROKEN TRUNK - The following job failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

lezcano
lezcano approved these changes Aug 21, 2023
View reviewed changes
Copy link
Collaborator

@lezcano lezcano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the clean-up!

@lezcano lezcano added module: dynamo release notes: dynamo module: numpy Related to numpy support, and also numpy compatibility of our operators labels Aug 21, 2023
@lezcano
Copy link
Collaborator

lezcano commented Aug 21, 2023

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Aug 21, 2023
@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Aug 21, 2023

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

This was referenced Aug 21, 2023
Closed
Closed
@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Aug 21, 2023

Merge failed

Reason: 1 mandatory check(s) failed. The first few are:

Dig deeper by viewing the failures on hud

Details for Dev Infra team Raised by workflow job

Failing merge rule: Core Maintainers

@lezcano
Copy link
Collaborator

lezcano commented Aug 21, 2023

@pytorchbot merge -i

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Aug 21, 2023

Merge started

Your change will be merged while ignoring the following 1 checks: trunk / macos-12-py3-arm64 / build

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lezcano lezcano lezcano approved these changes

@mruberry mruberry Awaiting requested review from mruberry mruberry is a code owner

@ngimel ngimel Awaiting requested review from ngimel

Assignees

No one assigned

Labels

ciflow/trunk Trigger trunk jobs on your pull request Merged module: dynamo module: numpy Related to numpy support, and also numpy compatibility of our operators open source release notes: dynamo

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ev-br @lezcano @pytorchmergebot @pytorchbot